Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: font-awesome font loading #2295

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: font-awesome font loading #2295

merged 2 commits into from
Dec 7, 2023

Conversation

ckniffen
Copy link
Contributor

@ckniffen ckniffen commented Dec 7, 2023

Had to move the font file location so that they are found up after Redocly does its magic.

@ckniffen
fix: font-awesome font loading
fccd0e8 
Had to move the font file location to be found up after redocly does its
magic.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Link check report. 553607 links checked.
58 broken links found:
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-purple.svg
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-green.svg
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-orange.svg
File: out/xrp-overview.html Link: ./img/backgrounds/xrp-overview-blue.svg
File: out/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-magenta.svg
File: out/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-green-2.svg
File: out/history.html Link: ./img/backgrounds/history-orange.svg
File: out/history.html Link: ./img/backgrounds/history-purple.svg
File: out/impact.html Link: ./img/backgrounds/community-purple.svg
File: out/impact.html Link: ./img/backgrounds/home-green.svg
File: out/impact.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/impact.html Link: ./img/backgrounds/cta-calculator-green.svg
File: out/dev-tools.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/dev-tools.html Link: ./img/backgrounds/cta-home-green.svg
File: out/contribute.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/contribute.html Link: ./img/backgrounds/cta-community-green.svg
File: out/developer-funding.html Link: ./img/backgrounds/funding-purple.svg
File: out/developer-funding.html Link: ./img/backgrounds/funding-orange.svg
File: out/code-samples.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/index.html Link: ./img/backgrounds/home-purple.svg
File: out/index.html Link: ./img/backgrounds/home-green.svg
File: out/index.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/index.html Link: ./img/backgrounds/cta-home-green.svg
File: out/index.html Link: ./img/backgrounds/cta-home-magenta.svg
File: out/ambassadors.html Link: ./img/backgrounds/ambassador-purple.svg
File: out/docs.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/docs.html Link: ./img/backgrounds/cta-home-green.svg
File: out/events.html Link: ./img/backgrounds/events-orange.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-purple.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-green.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-orange.svg
File: out/ja/xrp-overview.html Link: ./img/backgrounds/xrp-overview-blue.svg
File: out/ja/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-magenta.svg
File: out/ja/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-green-2.svg
File: out/ja/history.html Link: ./img/backgrounds/history-orange.svg
File: out/ja/history.html Link: ./img/backgrounds/history-purple.svg
File: out/ja/impact.html Link: ./img/backgrounds/community-purple.svg
File: out/ja/impact.html Link: ./img/backgrounds/home-green.svg
File: out/ja/impact.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/ja/impact.html Link: ./img/backgrounds/cta-calculator-green.svg
File: out/ja/dev-tools.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/ja/dev-tools.html Link: ./img/backgrounds/cta-home-green.svg
File: out/ja/contribute.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/ja/contribute.html Link: ./img/backgrounds/cta-community-green.svg
File: out/ja/developer-funding.html Link: ./img/backgrounds/funding-purple.svg
File: out/ja/developer-funding.html Link: ./img/backgrounds/funding-orange.svg
File: out/ja/code-samples.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/ja/index.html Link: ./img/backgrounds/home-purple.svg
File: out/ja/index.html Link: ./img/backgrounds/home-green.svg
File: out/ja/index.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/ja/index.html Link: ./img/backgrounds/cta-home-green.svg
File: out/ja/index.html Link: ./img/backgrounds/cta-home-magenta.svg
File: out/ja/ambassadors.html Link: ./img/backgrounds/ambassador-purple.svg
File: out/ja/docs.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/ja/docs.html Link: ./img/backgrounds/cta-home-green.svg
File: out/ja/events.html Link: ./img/backgrounds/events-orange.svg

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/redocly-font-awesome/

Style Report

@mDuo13 mDuo13 added this to the Toolchain-Migration-Redocly milestone Dec 7, 2023
mDuo13
mDuo13 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that fa-* classes work in pages after this change. 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Link check report. 553607 links checked.
58 broken links found:
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-purple.svg
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-green.svg
File: out/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-orange.svg
File: out/xrp-overview.html Link: ./img/backgrounds/xrp-overview-blue.svg
File: out/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-magenta.svg
File: out/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-green-2.svg
File: out/history.html Link: ./img/backgrounds/history-orange.svg
File: out/history.html Link: ./img/backgrounds/history-purple.svg
File: out/impact.html Link: ./img/backgrounds/community-purple.svg
File: out/impact.html Link: ./img/backgrounds/home-green.svg
File: out/impact.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/impact.html Link: ./img/backgrounds/cta-calculator-green.svg
File: out/dev-tools.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/dev-tools.html Link: ./img/backgrounds/cta-home-green.svg
File: out/contribute.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/contribute.html Link: ./img/backgrounds/cta-community-green.svg
File: out/developer-funding.html Link: ./img/backgrounds/funding-purple.svg
File: out/developer-funding.html Link: ./img/backgrounds/funding-orange.svg
File: out/code-samples.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/index.html Link: ./img/backgrounds/home-purple.svg
File: out/index.html Link: ./img/backgrounds/home-green.svg
File: out/index.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/index.html Link: ./img/backgrounds/cta-home-green.svg
File: out/index.html Link: ./img/backgrounds/cta-home-magenta.svg
File: out/ambassadors.html Link: ./img/backgrounds/ambassador-purple.svg
File: out/docs.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/docs.html Link: ./img/backgrounds/cta-home-green.svg
File: out/events.html Link: ./img/backgrounds/events-orange.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-purple.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-green.svg
File: out/ja/xrp-ledger-overview.html Link: ./img/backgrounds/cta-xrpl-overview-orange.svg
File: out/ja/xrp-overview.html Link: ./img/backgrounds/xrp-overview-blue.svg
File: out/ja/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-magenta.svg
File: out/ja/xrp-overview.html Link: ./img/backgrounds/cta-xrp-overview-green-2.svg
File: out/ja/history.html Link: ./img/backgrounds/history-orange.svg
File: out/ja/history.html Link: ./img/backgrounds/history-purple.svg
File: out/ja/impact.html Link: ./img/backgrounds/community-purple.svg
File: out/ja/impact.html Link: ./img/backgrounds/home-green.svg
File: out/ja/impact.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/ja/impact.html Link: ./img/backgrounds/cta-calculator-green.svg
File: out/ja/dev-tools.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/ja/dev-tools.html Link: ./img/backgrounds/cta-home-green.svg
File: out/ja/contribute.html Link: ./img/backgrounds/cta-community-purple.svg
File: out/ja/contribute.html Link: ./img/backgrounds/cta-community-green.svg
File: out/ja/developer-funding.html Link: ./img/backgrounds/funding-purple.svg
File: out/ja/developer-funding.html Link: ./img/backgrounds/funding-orange.svg
File: out/ja/code-samples.html Link: ./img/backgrounds/xrpl-overview-orange.svg
File: out/ja/index.html Link: ./img/backgrounds/home-purple.svg
File: out/ja/index.html Link: ./img/backgrounds/home-green.svg
File: out/ja/index.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/ja/index.html Link: ./img/backgrounds/cta-home-green.svg
File: out/ja/index.html Link: ./img/backgrounds/cta-home-magenta.svg
File: out/ja/ambassadors.html Link: ./img/backgrounds/ambassador-purple.svg
File: out/ja/docs.html Link: ./img/backgrounds/cta-home-purple.svg
File: out/ja/docs.html Link: ./img/backgrounds/cta-home-green.svg
File: out/ja/events.html Link: ./img/backgrounds/events-orange.svg

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/redocly-font-awesome/

Style Report

@mDuo13 mDuo13 merged commit 05f49b4 into redocly-migration Dec 7, 2023
2 of 4 checks passed
@mDuo13 mDuo13 deleted the redocly-font-awesome branch December 7, 2023 23:18
ckniffen added a commit that referenced this pull request Dec 19, 2023
@ckniffen
fix: font-awesome font loading take 2
3b16934 
Some of the changes in #2295 are missing
@ckniffen ckniffen mentioned this pull request Dec 19, 2023
Merged
mDuo13 pushed a commit that referenced this pull request Jan 12, 2024
@ckniffen @mDuo13
fix: font-awesome font loading take 2
ed398a2 
Some of the changes in #2295 are missing
mDuo13 pushed a commit that referenced this pull request Jan 23, 2024
@ckniffen @mDuo13
fix: font-awesome font loading take 2
3682419 
Some of the changes in #2295 are missing
mDuo13 pushed a commit that referenced this pull request Jan 26, 2024
@ckniffen @mDuo13
fix: font-awesome font loading take 2
3ca214e 
Some of the changes in #2295 are missing
mDuo13 pushed a commit that referenced this pull request Feb 1, 2024
@ckniffen @mDuo13
fix: font-awesome font loading take 2
2b6e9be 
Some of the changes in #2295 are missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

@pdp2121 pdp2121 Awaiting requested review from pdp2121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Toolchain-Migration-Redocly
Development

Successfully merging this pull request may close these issues.
2 participants
@ckniffen @mDuo13