Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft clawback #2020

Closed
wants to merge 8 commits into from
Closed

draft clawback #2020

wants to merge 8 commits into from

Conversation

DennisDawson
Copy link
Contributor

No description provided.

@github-actions
Copy link

Link check report. 495072 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report

@github-actions
Copy link

Link check report. 498994 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report

@github-actions
Copy link

Link check report. 498994 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report

@github-actions
Copy link

Link check report. 498994 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report

1 similar comment
@github-actions
Copy link

Link check report. 498994 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report

@github-actions
Copy link

Link check report. 498994 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report

@github-actions
Copy link

Link check report. 498997 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Link check report. 498997 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/add_clawback/

Style Report


If there doesn't exist a trustline with the counterparty or that trustline's balance is 0, the error `tecNO_LINE` is returned.

The sub-field `issuer` within `Amount` represents the token holder's account ID rather than the issuer's.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this line should be moved to line 38(the Description column and Amount row). I think it is a very important detail that should be made more visible, otherwise it's easy for readers to skim pass through it.

@amarantha-k amarantha-k self-assigned this Aug 14, 2023
@amarantha-k
Copy link
Collaborator

Closing without merge as it has been superseded by PR #2111

@amarantha-k amarantha-k closed this Sep 6, 2023
@amarantha-k amarantha-k deleted the add_clawback branch September 6, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants