-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for more straightforward and faster code #125
Conversation
Pull Request Test Coverage Report for Build 7883397465Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mhliu0001. Most of the changes look good! I would just remove the comments for the S1 photon hits, or what was your plan there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I do not know if someone checked whether the result changed. If I change the version number back, and compare the old and new results. They are the same. So I think we are fine. Thumb to @mhliu0001 . |
These are some minor improvements that should not alter the behavior of fuse.