Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for more straightforward and faster code #125

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Conversation

mhliu0001
Copy link
Contributor

These are some minor improvements that should not alter the behavior of fuse.

@coveralls
Copy link

coveralls commented Feb 10, 2024

Pull Request Test Coverage Report for Build 7883397465

Details

  • 0 of 13 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 66.349%

Totals Coverage Status
Change from base Build 7845769381: -0.01%
Covered Lines: 1603
Relevant Lines: 2416

💛 - Coveralls

Copy link
Collaborator

@HenningSE HenningSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mhliu0001. Most of the changes look good! I would just remove the comments for the S1 photon hits, or what was your plan there?

fuse/plugins/detector_physics/s1_photon_hits.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HenningSE HenningSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks!

Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramirezdiego ramirezdiego merged commit e6aea36 into main Feb 13, 2024
2 of 3 checks passed
@ramirezdiego ramirezdiego deleted the performance branch February 13, 2024 15:11
@dachengx
Copy link
Contributor

I do not know if someone checked whether the result changed. If I change the version number back, and compare the old and new results. They are the same. So I think we are fine. Thumb to @mhliu0001 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants