Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240329 edit basload trace #325

Merged

Conversation

stefan-b-jakobsson
Copy link
Collaborator

No description provided.

@stefan-b-jakobsson
Copy link
Collaborator Author

stefan-b-jakobsson commented Mar 29, 2024

There might be something not right here still. While running the editor, I can't see any source code being displayed anywhere for bank 13.

Yes, you can wait looking at this PR while I try to figure out what's going on.

@stefan-b-jakobsson stefan-b-jakobsson marked this pull request as draft March 29, 2024 13:01
@mooinglemur
Copy link
Collaborator

somehow this causes the resulting rom_lst.h to end up with this on line 229388:

/* $FFF0 */ "NATURE\"\n.byt \"basload\", appversion_major, appversion_minor, appversion_patch",

Which looks like it truncated the line that said .segment "SIGNATURE"

@stefan-b-jakobsson
Copy link
Collaborator Author

I fixed the truncating issue affecting only segment selection lines.

@stefan-b-jakobsson
Copy link
Collaborator Author

I revisited this code from March. It looks like the output is correct after the fix on March 30.

@stefan-b-jakobsson stefan-b-jakobsson marked this pull request as ready for review July 28, 2024 18:30
@mooinglemur mooinglemur merged commit 5501419 into X16Community:master Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants