Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added domain exceptions + modified license description #19

Merged
merged 1 commit into from
May 21, 2024

Conversation

Neilblaze
Copy link
Member

Description

Added domain exceptions & modified LICENSE description of metrics.


Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@Neilblaze
Copy link
Member Author

Neilblaze commented May 21, 2024

Interesting, I've added DCO, still not approving 🤔 nvm, fixed 😆

Signed-off-by: Pratyay Banerjee <[email protected]>
Signed-off-by: neilblaze <[email protected]>
@frank-zsy
Copy link
Contributor

LTGM, thanks.

@frank-zsy frank-zsy merged commit 84542eb into X-lab2017:master May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants