-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated wheel release mechanism #511
base: master
Are you sure you want to change the base?
Conversation
186b969
to
673fe59
Compare
e26de5c
to
847c340
Compare
5b8c821
to
0f89463
Compare
53db44c
to
6c4dc65
Compare
Sorry, just discovering this thread :o, wow the amount of work is huge ! Honestly, these tests involving randomness are very bad designed, but I didn't know that back then :). About changing the AUC threshold from .7 to .69, this is not an issue at all. The only thing we are checking is that the model is learning something significantly better than random (which would lead to 0.5), so 0.65 or 0.6 would also be fine. About the darwin test filtering, this is due to # This is temporary
# At the moment, seeds are not cross platform as distributions in
# C++ depends on standard library shipped with compiler
import os
if os.name == 'posix':
import platform
if platform.system() == 'Darwin':
# We check that we get the same as what was recorded
np.testing.assert_almost_equal(seeded_sample_1, seeded_sample) (note the "temporary"...). That is also bad designed. The test purpose was to check if with the same seed we were obtaining the same random numbers. But nothing really guarantees this and I guess an update in darwin random number generation can break this easily. I would thus simply remove this part of the test as well as all |
10a6983
to
b139e0e
Compare
b139e0e
to
748fbdd
Compare
748fbdd
to
58b2307
Compare
b0f3f63
to
338ac93
Compare
e5d66d1
to
cc325a3
Compare
Biggest change really is now,
Fixes somethings from #504
OSX still has some weird issues with random, and I'm guessing this is the reason why some real tests are failing now
for instance
I changed it from
.7
to.69
, but I'm not sure it really should be changed, maybe it's ok?@Mbompr thoughts?
With this pull request, we should be able to publish new wheels to both test-pypi repo on master merge
And
push to pypi regular on release/tag