-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor config #182
Merged
Merged
Refactor config #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize auth as empty object to be able to overwrite it.
Deploy will be handled by CF
Instead of baking the pre-built site in the Docker image, the site has to be built when spinning up a Docker container
olafveerman
force-pushed
the
feature/181-new-config-setup
branch
from
May 8, 2018 20:43
c359a18
to
2ab5416
Compare
When this receives your thumbsup, I need to change this in the |
@olafveerman Couple of improvements:
Overall it works great! 👍 |
- set default CMD to make it easier to run the container - add docs to Readme - ignore node_modules and dist - print message so user knows when serve.sh is done
olafveerman
force-pushed
the
feature/181-new-config-setup
branch
from
May 9, 2018 12:24
895a05f
to
cdd2360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor config so it's easier to deploy the frontend with CF. Fix #181 and #183
This makes significant changes to the Docker image. The built site will not be pre-baked in the image, instead it is to be built when the container starts. This allows environment variables to be passed like below.
@danielfdsilva This works well, but is slow. Launching the container takes a couple of minutes.
Also, when you build the image, make sure you have do it from a clean project without
node_modules
ordist
.