Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dictid by lexiconset #256

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Handle dictid by lexiconset #256

merged 2 commits into from
Dec 3, 2024

Conversation

mh-northlander
Copy link
Collaborator

@mh-northlander mh-northlander commented Dec 2, 2024 •
edited
Loading

resolve #252

Remove dictionary-id handling from WordIdTable which is a part of a lexicon.
Instead LexiconSet (and WordLookup) is responsible for that.

Also let DictionaryPrinter use Lexicon.wordIds method instead of using WordIdTable directly.

@mh-northlander mh-northlander added this to the 0.8 milestone Dec 2, 2024
@mh-northlander mh-northlander linked an issue Dec 2, 2024 that may be closed by this pull request
DictId handling by LexiconSet #252
Open
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mh-northlander mh-northlander merged commit adde77d into develop-v0.8 Dec 3, 2024
4 checks passed
@mh-northlander mh-northlander deleted the feature/252-dictid-lexiconset branch December 3, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuma-t kazuma-t kazuma-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

DictId handling by LexiconSet
2 participants
@mh-northlander @kazuma-t