Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-1997: adjust manageAndReturnTypedDisposable #964

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

dustinlessard-wf
Copy link
Contributor

@dustinlessard-wf dustinlessard-wf commented Nov 20, 2024

Motivation

We intend to make a null-safety related change to w_common that is technically a breaking change in which over_react is the only consumer impacted. Rather than release a major, we intend to release the change as a minor and prepare an update pr to over_react ahead of time. This is that pr.

Changes

  • Update manageAndReturnTypedDisposable to reflect the updated nullable bound, and that impacts over_react because the method is overridden.

Release Notes

  • Update manageAndReturnTypedDisposable to reflect the updated nullable bound from w_common

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@dustinlessard-wf dustinlessard-wf marked this pull request as ready for review November 20, 2024 21:00
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 assuming CI passes

@greglittlefield-wf
Copy link
Contributor

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 8e97ecb into master Nov 20, 2024
9 checks passed
@rmconsole3-wf rmconsole3-wf deleted the FEDX-1997 branch November 20, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants