FEDX-1997: adjust manageAndReturnTypedDisposable
#964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We intend to make a null-safety related change to w_common that is technically a breaking change in which over_react is the only consumer impacted. Rather than release a major, we intend to release the change as a minor and prepare an update pr to over_react ahead of time. This is that pr.
Changes
manageAndReturnTypedDisposable
to reflect the updated nullable bound, and that impacts over_react because the method is overridden.Release Notes
manageAndReturnTypedDisposable
to reflect the updated nullable bound from w_commonReview
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: