Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-2979 Clean up dependency ranges, clean out the lint trap #934

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Jul 23, 2024

Motivation

  1. During the null safety migration, we opened up some rather massive dependency ranges to support both null safe, and non-null safe dependencies.
  2. After upgrading these dependencies, and the SDK minimum - we have some new lints we should address.

Now that this lib is null safe, those ranges are inaccurate and unnecessary - and can cause bloated CI times due to slower pub get times.

Changes

  1. Bump the Dart SDK Minimum to 2.19.0
  2. Bump all package dependency minimums to their minimum null safe version
  3. Clean the lint trap

now that we’re done with null safety
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf changed the title Clean up dependency ranges Clean up dependency ranges, clean out the lint trap Jul 23, 2024
@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review July 23, 2024 15:48
@aaronlademann-wf aaronlademann-wf changed the title Clean up dependency ranges, clean out the lint trap FED-2979 Clean up dependency ranges, clean out the lint trap Jul 23, 2024
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit e64a1ca into master Aug 9, 2024
5 checks passed
@rmconsole6-wk rmconsole6-wk deleted the clean-up-dep-ranges branch August 9, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants