FED-1720 Conditionally null-safe builder output (tests)

[sydneyjodon-wk]

Motivation

Right now in the null safety branch, we have some logic in place around conditionally generating null-safe code, in order to support consumers migrating to null safety.

We currently support language version comments in files, but we don't have a mechanism for detecting package-level language versions.

Changes

• Merge in implementation of package-config-based implementation present in spike branch: null-safety...null-safety-conditional-builder
• Add tests and test cases for
  • different package-level versions
    • Can use test packages in in test branch and pub run build_runner build to inspect output of generated code, looking for comment that says how nullability was calculated
  • different library-level language versions
    • Different boilerplate versions
      • Note: this is likely going to be have a LOT of test cases, to ensure all versions of boilerplate work in both null safe and non-null-safe code.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
    • CI passes
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Frameworks Design member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary3-wk]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[greglittlefield-wf]

Just one comment, otherwise copied over tests look good!

[greglittlefield-wf]

Just one small comment about an additional test coverage, otherwise this looks perfect, and I'll be ready to QA after that's addressed

[greglittlefield-wf]

• Changes look good
  • All tests under non_null_safe_builder_integration_tests look good, verified via:

    git diff \
        origin/master:test/over_react/component_declaration/builder_integration_tests \
        origin/FED-1720-conditionally-null-safe-builder:test/over_react/component_declaration/non_null_safe_builder_integration_tests

• Newly-added tests run and pass in CI

+10

[sydneyjodon-wk]

+1 in spirit

[kealjones-wk]

+1