FED-1956 Gold file workflow improvements #865
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| file.copySync(newPath); | ||
| } | ||
|
|
||
| print('Building files in temporary directory ${tmpSourceDir.path}'); |
There was a problem hiding this comment.
This is kind of hacky, but it's way better than our current workflow of manually updating them.
There was a problem hiding this comment.
All these renames are just from me deleting all golds within test_fixtures/gold_output_files/ and running dart tool/update_gold_output_files.dart to repopulate them with consistent paths (see also over_react_builder_test.dart for path updates).
rmconsole5-wk
changed the title
There was a problem hiding this comment.
Is this file supposed to be referenced somewhere? Or is this a followup ticket?
There was a problem hiding this comment.
It looks like the tests for these files verify builder errors, but don't actually check the output of the file, so this being unused is expected.
Rather than adding an exception for these, I figured we could just check em in and have em be unused 🤷. Sorry, forgot to note that in that other thread.
...s/gold_output_files/mixin_based/missing_over_react_g_part/library.over_react.g.dart.goldFile
Outdated
Show resolved
Hide resolved
Motivation
We didn't have a great workflow for updating gold files in response to builder changes.
Also, it looks like there were some inconsistencies in the paths for the test fixture source files and their corresponding golds.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: