FED-1763 Fix reenabled contributor tests

[greglittlefield-wf]

Motivation

In a previous over_react release, we had to disable some diagnostics and assists that imported over_react builder code due to issues with the plugin running in unsound null safety.

As part of the over_react null-safety major release, we want to reenable those diagnostics, and have done so in v5_wip.

As a result to test refactors and other changes that were made while those contributors were disabled, there are test failures that need to be addressed, mostly to do with unique file names.

Changes

• Update AnalysisDriverTestBase to automatically substitute auto-generated filenames within source (using {{FILE_BASENAME_WITHOUT_EXTENSION}})
• Uncomment tests:
  • test/integration/assists/toggle_statefulness_test.dart
  • test/integration/diagnostics/boilerplate_validator_test.dart
• Fix all analyzer_plugin test failures
  • Update tests referencing .over_react.g.dart parts to reference the correct auto-generated file names. Without them, we get unrelated BoilerplateValidatorDiagnostic errors in unrelated tests.
    • Most of these are just switching to {{FILE_BASENAME_WITHOUT_EXTENSION}}, but some required more custom updates
  • Fix toggle statefulness diagnostic due to logic (in boilerplate_assist_apis.dart) being broken while it was turned off, in the last analyzer package upgrade

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
    • All CI is passing (analyzer_plugin tests were previously failing in v5_wip)
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Frameworks Design member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[greglittlefield-wf]

Added this during debugging.

Before: Instance of 'SourceSelection'

After:

SourceSelection {target: class #FooComponent# extends, offset: 181, length: 12}. Preview:
  ╷
8 │ class FooComponent extends UiComponent2<FooProps> {
  │       ^^^^^^^^^^^^
  ╵

[sydneyjodon-wk]

+10

• CI passes

[sydneyjodon-wk]

@Workiva/release-management-p