Work around presets ignoring excluded tag args

Workiva · Oct 10, 2024 · 922d535 · 922d535
1 parent 5412fef
commit 922d535
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/dart_ci.yml b/.github/workflows/dart_ci.yml
@@ -92,9 +92,9 @@ jobs:
           DART_VERSION="${{ steps.setup-dart.outputs.dart-version }}"
           TEST_ARGS=""
           if [[ "$DART_VERSION" =~ ^3 ]]; then
-            TEST_ARGS="--exclude-tags=dart-2-only"
+            TEST_ARGS="--preset=no-dart-2"
           fi
-          dart test -P vm $TEST_ARGS
+          dart test --preset vm $TEST_ARGS
         if: always() && steps.install.outcome == 'success' && steps.build.outcome == 'success'
 
       - name: Run tests (DDC)
@@ -156,9 +156,9 @@ jobs:
           DART_VERSION="${{ steps.setup-dart.outputs.dart-version }}"
           TEST_ARGS=""
           if [[ "$DART_VERSION" =~ ^3 ]]; then
-            TEST_ARGS="--exclude-tags=dart-2-only"
+            TEST_ARGS="--preset=no-dart-2"
           fi
-          dart test -p vm $TEST_ARGS -- test/vm_tests/builder
+          dart test --preset vm $TEST_ARGS -- test/vm_tests/builder
 
   analyzer_plugin:
     runs-on: ubuntu-latest

diff --git a/dart_test.yaml b/dart_test.yaml
@@ -12,6 +12,9 @@ presets:
     paths:
       - test/vm_tests/
 
+  no-dart-2:
+    exclude_tags: dart-2-only
+
   dartdevc:
     exclude_tags: no-ddc
     paths: