Skip to content

Commit

Permalink
Fix error message assertion in Dart 3
Browse files Browse the repository at this point in the history
  • Loading branch information
greglittlefield-wf committed Oct 16, 2024
1 parent d64668c commit 8df1dc0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions test/over_react/component/lazy_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,8 @@ sharedNestedPropConversionTests(UiFactory<TestJsProps> builder, {bool isJsCompon
// DDC error message
matches(
RegExp(r"Expected a value of type 'Map[^']*', but got one of type '(Native|Legacy)JavaScriptObject'")),
// dart2js error message
matches(RegExp(r"type '(Unknown|Plain)JavaScriptObject' is not a subtype of type 'Map[^']*'")),
// Dart 2 dart2js, Dart 3 DDC error message
matches(RegExp(r"type '(Unknown|Plain|Legacy)JavaScriptObject' is not a subtype of type 'Map[^']*'")),
)),
]);
if (!isJsComponent) {
Expand Down
4 changes: 2 additions & 2 deletions test/over_react/util/prop_conversion_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1083,9 +1083,9 @@ main() {
// DDC error message
matches(RegExp(
r"Expected a value of type 'Map[^']*', but got one of type '(Native|Legacy)JavaScriptObject'")),
// dart2js error message
// Dart 2 dart2js, Dart 3 DDC error message
matches(RegExp(
r"type '(Unknown|Plain)JavaScriptObject' is not a subtype of type 'Map[^']*'")),
r"type '(Unknown|Plain|Legacy)JavaScriptObject' is not a subtype of type 'Map[^']*'")),
)),
]);

Expand Down

0 comments on commit 8df1dc0

Please sign in to comment.