Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(side-panel): Filter out invalid DOM prop #3080

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix(side-panel): Filter out invalid DOM prop #3080

merged 3 commits into from
Dec 20, 2024

Conversation

NicholasBoll
Copy link
Member

@NicholasBoll NicholasBoll commented Dec 18, 2024 •
edited
Loading

Summary

Filter out the openDirection prop so it doesn't get forwarded to the <button> element.

Release Category

Components

Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

@NicholasBoll NicholasBoll added the ready for review Code is ready for review label Dec 18, 2024
@github-actions github-actions bot requested a review from alanbsmith December 18, 2024 21:10
@NicholasBoll NicholasBoll added automerge and removed ready for review Code is ready for review labels Dec 18, 2024
@alanbsmith alanbsmith enabled auto-merge (squash) December 18, 2024 21:16
@cypress Cypress
Copy link

cypress bot commented Dec 18, 2024 •
edited
Loading

Workday/canvas-kit    Run #8144

Run Properties:  status check passed Passed #8144  •  git commit 74eae4c023 ℹ️: Merge 7cdd1cda525806ce6d8f127279cd0466607192e2 into 28f4c8e1b4122413b74aa3078d61...
Project Workday/canvas-kit
Branch Review refs/pull/3080/merge
Run status status check passed Passed #8144
Run duration 05m 13s
Commit git commit 74eae4c023 ℹ️: Merge 7cdd1cda525806ce6d8f127279cd0466607192e2 into 28f4c8e1b4122413b74aa3078d61...
Committer Nicholas Boll
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1006
View all changes introduced in this branch ↗︎

@mannycarrera4
Copy link
Contributor

This might be something with the codemod version, seeing a few different issues online:

benjamn/recast#1406

facebook/jscodeshift#534

@github-actions github-actions bot added the ready for review Code is ready for review label Dec 20, 2024
@alanbsmith alanbsmith disabled auto-merge December 20, 2024 17:22
@alanbsmith alanbsmith enabled auto-merge (squash) December 20, 2024 17:22
@alanbsmith alanbsmith disabled auto-merge December 20, 2024 17:43
@alanbsmith alanbsmith enabled auto-merge (squash) December 20, 2024 17:43
@alanbsmith alanbsmith merged commit b005114 into Workday:support Dec 20, 2024
18 checks passed
@NicholasBoll NicholasBoll deleted the fix/filter-invalid-dom-prop branch December 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mannycarrera4 mannycarrera4 mannycarrera4 approved these changes

@alanbsmith alanbsmith Awaiting requested review from alanbsmith

Assignees
No one assigned
Labels
automerge ready for review Code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasBoll @mannycarrera4 @alanbsmith