Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert Select Preview Removal #2933

Merged

Conversation

josh-bagwell
Copy link
Contributor

@josh-bagwell josh-bagwell commented Sep 19, 2024

Summary

Fixes: #2926

Revert removing Select from Preview until we figure out grouping in Menu.

Release Category

Components


Where Should the Reviewer Start?

/modules/preview-react/select

@josh-bagwell josh-bagwell self-assigned this Sep 19, 2024
@josh-bagwell josh-bagwell marked this pull request as ready for review September 19, 2024 21:54
Copy link

cypress bot commented Sep 19, 2024

Workday/canvas-kit    Run #7778

Run Properties:  status check passed Passed #7778  •  git commit cc06999677 ℹ️: Merge 16c9c458a82321e9280652abcc107d0704f34d46 into 19a43f88e6d0db8567ae0afb0e41...
Project Workday/canvas-kit
Branch Review add-select-preview-24-09
Run status status check passed Passed #7778
Run duration 03m 59s
Commit git commit cc06999677 ℹ️: Merge 16c9c458a82321e9280652abcc107d0704f34d46 into 19a43f88e6d0db8567ae0afb0e41...
Committer Josh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 29
Tests that did not run due to a developer annotating a test with .skip  Pending 16
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1097
View all changes introduced in this branch ↗︎
UI Coverage  21.84%
  Untested elements 1795  
  Tested elements 499  
Accessibility  99.09%
  Failed rules  5 critical   6 serious   0 moderate   2 minor
  Failed elements 460  

@josh-bagwell josh-bagwell changed the title Add select preview 24 09 chore: Revert Select Preview Removal Sep 19, 2024
@alanbsmith alanbsmith merged commit 6f4f525 into Workday:prerelease/major Sep 23, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants