Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cypress flaky fixes #2919

Closed

Conversation

josh-bagwell
Copy link
Contributor

Summary

Fixes: #2900

This is too fix Cypress flaky specs that were caused from the Webpack Upgrade

Release Category

Infrastructure


Where Should the Reviewer Start?

/cypress/component

@josh-bagwell josh-bagwell changed the title chore: Flaky fixes chore: Cypress flaky fixes Sep 12, 2024
@josh-bagwell josh-bagwell self-assigned this Sep 12, 2024
@josh-bagwell josh-bagwell linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link

cypress bot commented Sep 12, 2024

Workday/canvas-kit    Run #7983

Run Properties:  status check passed Passed #7983  •  git commit 32a1b2a537 ℹ️: Merge 3ad448efdb3f198877b5d27a84e4df337cea0bcc into 6259a19bb3bb9912528c6f949bca...
Project Workday/canvas-kit
Branch Review flaky-fix-24-09
Run status status check passed Passed #7983
Run duration 03m 19s
Commit git commit 32a1b2a537 ℹ️: Merge 3ad448efdb3f198877b5d27a84e4df337cea0bcc into 6259a19bb3bb9912528c6f949bca...
Committer Josh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 18
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1033
View all changes introduced in this branch ↗︎
UI Coverage  21.8%
  Untested elements 1548  
  Tested elements 429  
Accessibility  99.2%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 176  

@josh-bagwell josh-bagwell marked this pull request as ready for review September 18, 2024 17:46
@josh-bagwell josh-bagwell added the on hold PR is on hold until further notice label Sep 24, 2024
@josh-bagwell
Copy link
Contributor Author

josh-bagwell commented Sep 24, 2024

This is on hold until after v12. This is lower priority as this won't block PR's from getting merged.

@mannycarrera4 mannycarrera4 removed the on hold PR is on hold until further notice label Nov 5, 2024
@josh-bagwell josh-bagwell changed the base branch from prerelease/major to master November 5, 2024 19:44
@josh-bagwell josh-bagwell changed the base branch from master to prerelease/major November 5, 2024 19:46
@josh-bagwell
Copy link
Contributor Author

Closed as this was built off of major and we decided to build off of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants