-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Avatar to use createStencil and createComponent #2793
Merged
alanbsmith
merged 40 commits into
Workday:prerelease/major
from
kaconant:avatarRefactorMajor
Aug 7, 2024
Merged
chore: Update Avatar to use createStencil and createComponent #2793
alanbsmith
merged 40 commits into
Workday:prerelease/major
from
kaconant:avatarRefactorMajor
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill WIP and added notes
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Co-authored-by: Manuel Carrera <[email protected]>
Co-authored-by: Manuel Carrera <[email protected]>
Co-authored-by: Manuel Carrera <[email protected]>
Co-authored-by: Manuel Carrera <[email protected]>
mannycarrera4
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Way to push through, thank you for working on this!
mannycarrera4
added
automerge
and removed
ready for review
Code is ready for review
labels
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1738
Refactored Avatar to use our new styling utilities and tokens. Also updated documentation to use MDX.
Release Category
Components
Release Note
The Avatar component has been refactored to use our new tokens and styling utilities. The changes below highlight the breaking changes to the API.
BREAKING CHANGES
SystemIconCircle
for sizing.Avatar.Size
is no longer supported. Thesize
prop type has change to accept the following:"extraExtraLarge" | "extraLarge" | "large" | "medium" | "small" | "extraSmall" | (string{})
Avatar.Variant
is no longer supported. EnumAvatarVariant
has been removed. Thevariant
type prop now accepts"dark" | "light"
as
prop now accepts any element, not justdiv
.Checklist
Will do the following once have a more stable branch!
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif