Skip to content

Commit

Permalink
feat: Add Divider component
Browse files Browse the repository at this point in the history
  • Loading branch information
alanbsmith committed Aug 12, 2024
1 parent 4fc6226 commit 46212c4
Show file tree
Hide file tree
Showing 12 changed files with 363 additions and 1 deletion.
52 changes: 52 additions & 0 deletions modules/preview-react/divider/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
Apache License, Version 2.0 Apache License Version 2.0, January 2004

http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.
"License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document.
"Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License.
"Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
"You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License.
"Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files.
"Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types.
"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below).
"Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof.
"Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution."
"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work.

2. Grant of Copyright License.
Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form.

3. Grant of Patent License.
Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed.

4. Redistribution.
You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:
You must give any other recipients of the Work or Derivative Works a copy of this License; and You must cause any modified files to carry prominent notices stating that You changed the files; and You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.

5. Submission of Contributions.
Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions.

6. Trademarks.
This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty.
Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License.

8. Limitation of Liability.
In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability.
While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

©2021 Workday, Inc. All rights reserved. Workday and the Workday logo are registered trademarks of Workday, Inc. All other brand and product names are trademarks or registered trademarks of their respective holders.


Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
11 changes: 11 additions & 0 deletions modules/preview-react/divider/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

# Canvas Kit Divider

<a href="https://github.com/Workday/canvas-kit/tree/master/modules/preview-react/README.md">
<img src="https://img.shields.io/badge/PREVIEW-beta-blueviolet" alt="PREVIEW: Beta" />
</a> This component is work in progress and currently in prerelease.

A divider to segment and visually organize content

View the [documentation for Divider](https://workday.github.io/canvas-kit/?path=/docs/preview-divider-react)
on Storybook.
1 change: 1 addition & 0 deletions modules/preview-react/divider/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './lib/Divider';
56 changes: 56 additions & 0 deletions modules/preview-react/divider/lib/Divider.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import * as React from 'react';
import {createComponent} from '@workday/canvas-kit-react/common';
import {createStencil, handleCsProp, CSProps, calc, cssVar} from '@workday/canvas-kit-styling';
import {system} from '@workday/canvas-tokens-web';

export const dividerStencil = createStencil({
vars: {
space: cssVar(system.space.x4),
},
base: ({space}) => {
return {
display: 'block',
height: 1,
border: 'none',
borderTop: `1px solid ${system.color.border.divider}`,
margin: `${calc.divide(space, 2)} 0`,
};
},
});

interface DividerProps extends CSProps {
space?: string;
}

/**
* # Divider
* A divider to segment and visually organize content. By default, it renders a semantic `<hr>` element.
*
* [View Docs](https://workday.github.io/canvas-kit/?path=/docs/preview-divider-react)
*
* The `space` prop will equally apply top and bottom margin styles.
* In the example below, `x2` (0.5rem), adds `0.25rem` margin to the top and `0.25rem` to the bottom
*
* @example
* ```tsx
* import { Divider } from '@workday/canvas-kit-preview-react/divider';
* import {system} from '@workday/canvas-tokens-web';
*
* <Divider space={system.space.x2} />
*
* ```
*
* ## Accessibility
*
* Screen readers announce `<hr>` elements to alert users to a break in content. If you're using `Divider` as a purely decorative element and not a thematic break, you should use `aria-hidden` to prevent screen readers from announcing it.
*
* ```tsx
* <Divider aria-hidden={true} />
*```
*/
export const Divider = createComponent('hr')({
displayName: 'Divider',
Component: ({space, ...elemProps}: DividerProps, ref, Element) => (
<Element ref={ref} {...handleCsProp(elemProps, dividerStencil({space}))} />
),
});
13 changes: 13 additions & 0 deletions modules/preview-react/divider/spec/SSR.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/**
* @jest-environment node
*/
import React from 'react';
import {renderToString} from 'react-dom/server';
import {Divider} from '../';

describe('Divider', () => {
it('should render on a server without crashing', () => {
const ssrRender = () => renderToString(<Divider />);
expect(ssrRender).not.toThrow();
});
});
4 changes: 4 additions & 0 deletions modules/preview-react/divider/spec/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

{
"extends": "../../../../tsconfig.spec.json"
}
38 changes: 38 additions & 0 deletions modules/preview-react/divider/stories/Divider.stories.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@

import {SymbolDoc, Specifications} from '@workday/canvas-kit-docs';

import {Divider} from '@workday/canvas-kit-preview-react/divider';
import {Basic} from './examples/Basic';
import {CustomSpace} from './examples/CustomSpace';

<Meta title="Preview/Divider" component={Divider} />

# Divider

A `Divider` segments and visually organizes content.

## Installation

```sh
yarn add @workday/canvas-kit-preview-react
```

## Usage

Use a `Divider` to separate content and create visual hierarchy. Typically they are used between paragraph sections to indicate a break or shift in content. However, they can also be used as decorative elements to provide greater emphasis and visual hierarchy.

### Basic Example

By default, `Divider` renders a `<hr>` (horizontal rule) element with `0.5rem` of margin on top and bottom. The `space` prop allows you to adjust the vertical margin evenly. In the example below, the `Divider`s provide a subtle deliniation between each profile card without being as visually prominent as a `Card`. The `space` is adjusted to `0.25rem` which applied `0.125rem` to the top and bottom margin.

<ExampleCodeBlock code={Basic} />

### Custom Space

You might also want to apply custom space to `Divider` where the top and bottom margin are not equal. The best way to achieve this is with `createStyles` and the `cs` property. In the example below, the `Divider` is applied as a decorative element to add emphasis to the section heading. Custom styles are defined in the `createStyles` function outside the component and are passed to `Divider`'s `cs` prop. These styles remove the top margin and set the bottom margin to `1rem`.

<ExampleCodeBlock code={CustomSpace} />

## Component API

<SymbolDoc name="Divider" hideDescription />
105 changes: 105 additions & 0 deletions modules/preview-react/divider/stories/examples/Basic.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
import React from 'react';
import {Divider} from '@workday/canvas-kit-preview-react/divider';
import {createStyles} from '@workday/canvas-kit-styling';
import {system} from '@workday/canvas-tokens-web';
import {Avatar} from '@workday/canvas-kit-react/avatar';

const sectionStyles = createStyles({
display: 'flex',
flexDirection: 'column',
gap: system.space.x4,
maxWidth: '40rem',
});

export const Basic = () => {
const lastIndex = maintainerList.length - 1;
return (
<section className={sectionStyles}>
{maintainerList.map((maintainerData, index) => (
<>
<ProfileCard {...maintainerData} />
{index !== lastIndex && <Divider space={system.space.x1} />}
</>
))}
</section>
);
};

const maintainerList = [
{
id: '44883293',
name: 'Josh Bagwell',
bio: 'Software Development Engineer',
},
{
id: '338257',
name: 'Nicholas Boll',
bio: 'Principal Software Development Engineer',
},
{
id: '7966550',
name: 'Manuel Carrera',
bio: 'Sr. Software Development Engineer',
},
{
id: '146020',
name: 'James Fan',
bio: 'Sr. Software Development Engineer',
},
{
id: '48605821',
name: 'Raisa Primerova',
bio: 'Software Development Engineer',
},
{
id: '4818182',
name: 'Alan Smith',
bio: 'Principal Software Development Engineer',
},
];

const profileCardStyles = createStyles({
display: 'grid',
gridGap: '0.5rem',
gridTemplateColumns: '5rem 1fr',
gridTemplateRows: '1fr 1fr',
});

const profileCardAvatarStyles = createStyles({
gridColumn: '1',
gridRow: '1 / 3',
});

const profileCardHeadingStyles = createStyles({
...system.type.body.large,
fontWeight: system.fontWeight.bold,
gridColumn: '2/3',
gridRow: '1',
margin: 0,
});

const profileCardBodyStyles = createStyles({
...system.type.body.small,
gridColumn: '2',
gridRow: '2',
margin: 0,
});

interface ProfileCardProps {
id: string;
name: string;
bio: string;
}

const ProfileCard = ({id, name, bio}: ProfileCardProps) => (
<div className={profileCardStyles}>
<Avatar
size={Avatar.Size.xl}
url={`https://avatars.githubusercontent.com/u/${id}?v=4`}
altText={`${name}'s avatar`}
className={profileCardAvatarStyles}
/>
<h3 className={profileCardHeadingStyles}>{name}</h3>
<p className={profileCardBodyStyles}>{bio}</p>
</div>
);
32 changes: 32 additions & 0 deletions modules/preview-react/divider/stories/examples/CustomSpace.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import React from 'react';
import {Divider} from '@workday/canvas-kit-preview-react/divider';
import {createStyles} from '@workday/canvas-kit-styling';
import {system} from '@workday/canvas-tokens-web';

const headingStyles = createStyles({
...system.type.body.large,
fontWeight: system.fontWeight.bold,
margin: 0,
});

const bodyStyles = createStyles({
...system.type.body.small,
margin: 0,
});

const customDividerSpace = createStyles({
margin: `0 0 ${system.space.x4}`,
});

export const CustomSpace = () => {
return (
<section>
<h3 className={headingStyles}>Quote of the Day</h3>
<Divider cs={customDividerSpace} />
<p className={bodyStyles}>
"It is not our differences that divide us. It is our inability to recognize, accept, and
celebrate those differences." – Audre Lorde
</p>
</section>
);
};
4 changes: 4 additions & 0 deletions modules/preview-react/divider/stories/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

{
"extends": "../../../../tsconfig.stories.json"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import React from 'react';

import {StaticStates, ComponentStatesTable} from '@workday/canvas-kit-react/testing';
import {withSnapshotsEnabled} from '../../../../../utils/storybook';

import {Divider} from '@workday/canvas-kit-preview-react/divider';
import {system} from '@workday/canvas-tokens-web';

export default withSnapshotsEnabled({
title: 'Testing/Preview/Divider',
component: Divider,
});

export const DividerStates = () => {
return (
<StaticStates>
<ComponentStatesTable
columnProps={[{label: 'Default', props: {}}]}
rowProps={[
{
label: 'Default Space',
props: {},
},
{
label: 'Custom Space',
props: {space: system.space.x8},
},
]}
>
{props => {
return (
<div>
<h3 style={{margin: 0}}>Quote of the Day</h3>
<Divider {...props} />
<p style={{margin: 0}}>
"It is not our differences that divide us. It is our inability to recognize, accept,
and celebrate those differences." – Audre Lorde
</p>
</div>
);
}}
</ComponentStatesTable>
</StaticStates>
);
};
3 changes: 2 additions & 1 deletion modules/preview-react/index.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
export * from './color-picker';
export * from './divider';
export * from './form-field';
export * from './loading-sparkles';
export * from './menu';
export * from './pill';
export * from './radio';
export * from './segmented-control';
export * from './select';
export * from './side-panel';
export * from './status-indicator';
export * from './text-area';
export * from './text-input';
export * from './radio';

0 comments on commit 46212c4

Please sign in to comment.