Try: Remove wrappers from landing pages, and set zero margin to individual patterns.

[juanfra]

Description

Fixes #664

We're removing the wrappers of the landing pages, so that they're functional in the zoom out view. To respect the designs, we are also setting a zero margin to the patterns that are involved in these landing pages.

Screenshots

Screen.Recording.2024-11-05.at.15.16.15.mov

Testing Instructions

1. Create a page.
2. Insert a landing page. Choose from: "Shop homepage", "Business homepage", "Landing page for book", "Landing page for event", "Landing page for podcast".
3. Confirm that the design is ok.
4. Confirm that the styles of the main sections of the landing pages are accessible in zoom out view.

Repeat again, creating a page from the site editor.

[github-actions]

Preview changes

You can preview these changes by following the link below:

• Preview changes for twentytwentyfive

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[jasmussen]

Thanks for this, this works well for me:

It simplifies all the patterns to have a more basic nesting structure, and in the process it also ensures that selecting a section and applying a section style works the same, and as expected, whether you're zoomed or not!

[richtabor]

What do you think about applying margin 0 for any fullwidth patterns that can be inserted? That way they all work the same, and you don't end up with this:

[jasmussen]

What do you think about applying margin 0 for any fullwidth patterns that can be inserted? That way they all work the same, and you don't end up with this:

I'd support that. We'd still need the fewer wrappers, but it could simplify the code, no?

[juanfra]

What do you think about applying margin 0 for any fullwidth patterns that can be inserted? That way they all work the same, and you don't end up with this:

@richtabor @jasmussen the problem with setting all of them to zero is that the layout setting for block spacing won't affect any pattern.

[jasmussen]

the problem with setting all of them to zero is that the layout setting for block spacing won't affect any pattern.

I think that's fine, it will still affect paragraphs and other bits and pieces. I don't think there's an expectation that this particular property would affect the sections as such.

[juanfra]

Ok, I updated the rest of the full width patterns.

[jasmussen]

Ship it!