Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote block border issue solution for twenty twenty three theme #47487

Closed
wants to merge 1 commit into from
Closed

quote block border issue solution for twenty twenty three theme #47487

wants to merge 1 commit into from

Conversation

NidhiDhandhukiya74
Copy link

@NidhiDhandhukiya74 NidhiDhandhukiya74 commented Jan 27, 2023

Resolve the twenty twenty three theme quote block border issue.
#45547

What?

This PR is resolve the issue which is mentioned in this ticket :- #45547

Why?

As per the discussion in #45547 this issue we need to add support related to border-control so that user can give border as per their requirement.

How?

I have added the border-support for quote block.

Testing Instructions

  1. Choose Quote block in twenty-twenty-three theme.
  2. We have a border related setting in our editor side.
  3. Choose border-width, color, style as per your requirement.

Testing Instructions for Keyboard

Screenshots or screencast

Before:-

CleanShot 2023-02-03 at 11 16 50@2x

After:-
Editor side:-
CleanShot 202 CleanShot 2023-02-03 at 11 28 21@2x 3-02-03 at 11 27 58@2x
User side:-
CleanShot 2023-02-03 at 11 28 21@2x

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 27, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NidhiDhandhukiya74! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@carolinan
Copy link
Contributor

Thank you for the pull request.
Can you please fill out the pull request template with some more details, including testing instructions?

@NidhiDhandhukiya74
Copy link
Author

Hello @carolinan
I have updated my PR details as per your suggestion.
Thanks.

@carolinan carolinan added [Block] Quote Affects the Quote Block [Type] Enhancement A suggestion for improvement. labels Feb 27, 2023
@carolinan
Copy link
Contributor

Thank you, the PR works well for me.
I have tested it with Twenty Twenty-Three with and without https://core.trac.wordpress.org/ticket/57506 and in a few other themes.

There are two tests that have not run, the PR needs to be rebased so that it is updated with the lastest changes made to Gutenberg trunk.

@NidhiDhandhukiya74 NidhiDhandhukiya74 closed this by deleting the head repository Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants