Block editor: fix focus handler in Safari #31103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -12 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
ellatrix
commented
Apr 22, 2021
| @@ -113,6 +113,7 @@ describe( 'List', () => { | |||
| await clickBlockAppender(); | |||
| await page.keyboard.press( 'Enter' ); | |||
| await page.keyboard.type( '* ' ); | |||
| await page.evaluate( () => new Promise( window.requestIdleCallback ) ); | |||
There was a problem hiding this comment.
@youknowriad I found the issue I think. Feel free to include in your PR. I don't mind which PR we go with. We need to wait for this:
gutenberg/packages/block-editor/src/store/controls.js
Lines 24 to 36 in 3da717b
ellatrix
force-pushed
the
try/fix-focus-handler-safari
branch
from
ae86b13
to
57953f4
Compare
youknowriad
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
This looks good to me.
I think conditionally attaching event handlers for blocks though is probably something we should consider for all event handlers on blocks because of potential hidden async mode issues. That said this PR does solve the important one that we're aware of.
|
Thanks for the review!
Right, if the blocks is not selected, but the remaining ones are for the selected block, so that will attach instantly. |
|
The performance is apparently improved... 🤔 I think that's just because at a different time the tests run faster or slower. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handlers on a non-selected blocks could be attached with a delay, so always attach the handler.
Different from #30968 because we leave the other handlers to only attach on selected blocks. Let's see if there's any test failures in this case.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).