Tests: allow for PHPUnit 8/9 #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingo-d
approved these changes
Dec 11, 2023
GaryJones
requested changes
Dec 11, 2023
PHP_CodeSniffer 3.8.0 now allows for running the tests, which are based on the PHPCS native test suite, with PHPUnit 8 and 9.
This commit updates the package to take advantage of that.
Includes:
* Widening the PHPUnit version requirements.
* Adding the PHPUnit 8+ cache file to `.gitignore`.
* Updating the PHPUnit configuration to make sure that deprecations will always show, even when on a high PHPUnit 9.6 version.
* Updating the info in `CONTRIBUTING`.
* Simplifications to the `quicktest` and `test` workflows.
Also, the code coverage "high" run can now be run against PHP 8.3.
* Running PHPStan against PHP `latest` (couldn't previously be done due to the old PHPUnit version).
* Minor tweak to the PHPStan config to make sure PHP 8.x specific issues don't get flagged for this codebase.
* Removing a no longer needed `--ignore-platform*` argument.
* Updating the "setUp" method in one test to call the parent "setUp" method via the new method name.
Ref:
* PHPCSStandards/PHP_CodeSniffer 59
jrfnl
force-pushed
the
feature/phpunit-cross-version
branch
from
b4368d5 to
bb305f8
Compare
|
This closes #2123 issue if I'm not mistaken. |
GaryJones
approved these changes
Dec 12, 2023
jrfnl
commented
Dec 12, 2023
| @@ -127,8 +127,7 @@ jobs: | |||
| custom-cache-suffix: $(date -u "+%Y-%m") | |||
|
|
|||
| - name: "Set PHPCS version (lowest)" | |||
| if: ${{ matrix.phpcs_version == 'lowest' }} | |||
There was a problem hiding this comment.
Shoot! This condition shouldn't have been removed... Must have accidentally happened during one of the rebases....
I will fix this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP_CodeSniffer 3.8.0 now allows for running the tests, which are based on the PHPCS native test suite, with PHPUnit 8 and 9.
This commit updates the package to take advantage of that.
Includes:
.gitignore.CONTRIBUTING.quicktestandtestworkflows. Also, the code coverage "high" run can now be run against PHP 8.3.latest(couldn't previously be done due to the old PHPUnit version).--ignore-platform*argument.Ref: