Core: add new sniff to check formatting of OO declaration statement #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See 2254 for a detailed discussion of all options considered. Fixes 2254
jrfnl
force-pushed
the
feature/core-add-oo-declaration-check
branch
from
11bb652 to
619173b
Compare
dingo-d
approved these changes
Jun 20, 2023
|
FYI: when running this sniff over WP Core, I noticed that the fixer for the "no blank lines between class body and close brace" check also removed indentation. Not a biggie as when running with the complete WPCS ruleset, that gets fixed again via the All the same, I have submitted a fix to PHPCS to prevent this issue: squizlabs/PHP_CodeSniffer#3846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2254 for a detailed discussion of all options considered.
Fixes #2254