You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #2121 adds a temporary test exception for a test involving a function call to readonly().
Once the upstream PHPCS tokenizer supports PHP 8.2 - hopefully in PHPCS 3.8.0 -, the minimum supported PHPCS version should be raised and the exclusion should be removed.
While this may sound like a test tweak, it is in actual fact an issue with the sniff as the WP DeprecatedFunctions sniff will currently not report on the deprecated readonly() WP function, while it is important that it should as it will prevent plugins/themes from running into trouble when using the deprecated WP readonly() function with future PHP versions in which the function call will likely become a fatal error, so making this change as early as possible is highly recommended.
Rationale
PR #2121 adds a temporary test exception for a test involving a function call to
readonly()
.Once the upstream PHPCS tokenizer supports PHP 8.2 - hopefully in PHPCS 3.8.0 -, the minimum supported PHPCS version should be raised and the exclusion should be removed.
While this may sound like a test tweak, it is in actual fact an issue with the sniff as the WP
DeprecatedFunctions
sniff will currently not report on the deprecatedreadonly()
WP function, while it is important that it should as it will prevent plugins/themes from running into trouble when using the deprecated WPreadonly()
function with future PHP versions in which the function call will likely become a fatal error, so making this change as early as possible is highly recommended.References
Action Checklist
Once a PHPCS version is available which handles this correctly...
composer.json
and update the README and workflows etc.DeprecatedFunctions
sniff.The text was updated successfully, but these errors were encountered: