Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS 3.?.?: remove temporary test exclusion on PHP 8.2+ #2123

Closed
2 tasks done
jrfnl opened this issue Dec 4, 2022 · 1 comment
Closed
2 tasks done

PHPCS 3.?.?: remove temporary test exclusion on PHP 8.2+ #2123

jrfnl opened this issue Dec 4, 2022 · 1 comment
Milestone

Comments

@jrfnl
Copy link
Member

jrfnl commented Dec 4, 2022

Rationale

PR #2121 adds a temporary test exception for a test involving a function call to readonly().

Once the upstream PHPCS tokenizer supports PHP 8.2 - hopefully in PHPCS 3.8.0 -, the minimum supported PHPCS version should be raised and the exclusion should be removed.

While this may sound like a test tweak, it is in actual fact an issue with the sniff as the WP DeprecatedFunctions sniff will currently not report on the deprecated readonly() WP function, while it is important that it should as it will prevent plugins/themes from running into trouble when using the deprecated WP readonly() function with future PHP versions in which the function call will likely become a fatal error, so making this change as early as possible is highly recommended.

References

Action Checklist

Once a PHPCS version is available which handles this correctly...

  • Update the minimum supported PHPCS version in composer.json and update the README and workflows etc.
  • Remove the test exception from the DeprecatedFunctions sniff.
@jrfnl jrfnl added Upstream: PHPCS Status: Requirement not met On hold until WPCS supports a particular version of a dependency (PHP, PHP_CodeSniffer, etc.). labels Dec 4, 2022
@jrfnl
Copy link
Member Author

jrfnl commented Dec 12, 2023

Closed via 105a10c which was included in #2408

@jrfnl jrfnl closed this as completed Dec 12, 2023
@jrfnl jrfnl removed the Status: Requirement not met On hold until WPCS supports a particular version of a dependency (PHP, PHP_CodeSniffer, etc.). label Dec 12, 2023
@jrfnl jrfnl added this to the 3.1.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant