Rework pattern matching to use glob-style patterns #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This commit changes the signature and behavior of the Automaton keys, values, and items methods. This commit changes the signatures of Automaton keys, values, and items methods to the following: - keys([pattern, [how]]) - values([pattern, [how]]) - items([pattern, [houw]]) This commit changes the behavior of these APIs to process patterns as Unix shell-style glob patterns. The optional 'pattern' parameter can contain one or more of the following wildcards anywhere in the pattern: - '?': matches any single character. - '*': matches everything. The '\\' character is reserved as the escape character. For example, r'\\*' matches the literal '*' character. Each literal backslash must be either expressed as '\\\\' or as a raw r'\\' string. For example, r'\\t' matches '\\t'. The optional 'how' argument is used to control how patterns are matched using one of the following values: - 'ahocorasick.MATCH_PREFIX' (default): Yield keys with prefixes that match the given pattern. - 'ahocorasick.MATCH_WHOLE': Yield keys that fully match the given pattern.
|
@melsabagh-kw Let me review this in details... but I will not merge this in 2.0.0, rather this would be considered after since we had betas out and are about to release the final 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This PR changes the signature and behavior of the
keys,values, anditemsmethods of theAutomatonclass to process the optionalpatternparameter as a Unix shell glob-style pattern.Currently only the
'?'(match any single character) and'*'(match zero or more characters) wildcards are supported (so no character classes nor ranges). The'\'character is reserved as the wildcard escape character (so any literal'\'in apatternmust itself be escaped as'\\\\'orr'\\').The optional
wildcardparameter is gone. The values for the optionalhowparameter can be one ofMATCH_PREFIX(default; prefix match on keys) andMATCH_WHOLE(full match on keys).