Remove assert if json is too big for jsonencoder #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikobockerman
force-pushed
the
remove-assert-if-json-size-is-too-large
branch
from
0e60cee to
ac02a84
Compare
exg
reviewed
Jul 14, 2020
src/jsonop.c
Outdated
|
|
||
| jsonop_t *jsonop_make_request(async_t *async, http_client_t *client, | ||
| const char *uri, json_thing_t *request_body) | ||
| { | ||
| http_op_t *http_op = http_client_make_request(client, "POST", uri); | ||
| if (!http_op) | ||
| return NULL; | ||
| jsonencoder_t *encoder = json_encode(async, request_body); | ||
| ssize_t size = jsonencoder_size(encoder); |
There was a problem hiding this comment.
The behaviour of this assignment is implementation-defined (C standard 6.3.1.3). I suggest
size_t size = jsonencoder_size(encoder);
if (size > SSIZE_MAX) {
...
}
There was a problem hiding this comment.
Good idea! Changed accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.