expose env variables #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierchow
reviewed
Dec 5, 2019
| healthcheck({ | ||
| path: '/test', | ||
| versionFile: './package.json' | ||
| versionFile: './package.json', | ||
| env: { |
There was a problem hiding this comment.
why not just pass a list instead,
Suggested change
| env: { | |
| env: ['TEST_VAR_1', 'TEST_VAR_2] |
There was a problem hiding this comment.
It seems it's using a object to let you define the alias of the VAR name used for component. e.g
env: { 'alias1': 'VAR_NAME_1' }
while in deployment the env var is named as VAR_NAME_1.
|
Can we get a follow up on this ? I'd love to see that mainstream in our components.... @xavierchow @CCharlieLi care to review / merge / proceed with this ? |
CCharlieLi
approved these changes
Sep 23, 2020
|
don't merge this, we still have unaligned opened discussion: #1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1