Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese L10N strinsgs #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trickster-zx
Copy link

I have prepared a string file in Japanese. I would be very happy if you approve my PR.

@CLAassistant
Copy link

CLAassistant commented May 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@z16 z16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long, I commented on a few things. Some may be just me misunderstanding, because I don't speak Japanese and had to translate it with tools. Feel free to correct me, if I made a mistake somewhere.

<sys:String x:Key="Strings.ModeBorderless">枠無しウィンドウ</sys:String>
<sys:String x:Key="Strings.Cancel">キャンセル</sys:String>
<sys:String x:Key="Strings.Close">閉じる</sys:String>
<sys:String x:Key="Strings.CopyrightError">Error retrieving assembly copyright information</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this wasn't translated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't translate it because it never showed up in the actual application, so I will translate and commit it later.

<sys:String x:Key="Strings.Cancel">キャンセル</sys:String>
<sys:String x:Key="Strings.Close">閉じる</sys:String>
<sys:String x:Key="Strings.CopyrightError">Error retrieving assembly copyright information</sys:String>
<sys:String x:Key="Strings.CoreVersion">Core version:</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this? Or is there no good translation for it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation would be "コアバージョン" in Japanese, but I thought it would be difficult to understand intuitively if translated, so I left the original text as it is.

<sys:String x:Key="Strings.CopyrightError">Error retrieving assembly copyright information</sys:String>
<sys:String x:Key="Strings.CoreVersion">Core version:</sys:String>
<sys:String x:Key="Strings.CreateProfile">新規プロファイル</sys:String>
<sys:String x:Key="Strings.Display">Display</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, why no translation?

<sys:String x:Key="Strings.Height">高さ</sys:String>
<sys:String x:Key="Strings.RegionJP">日本</sys:String>
<sys:String x:Key="Strings.Launch">起動</sys:String>
<sys:String x:Key="Strings.LauncherVersion">Launcher version:</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as Core version:, why no translation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the mention above against "core version", the "Launcher" is difficult for many non-engineers to understand, so we have left it in its original form.

<sys:String x:Key="Strings.AdjustGamma">明るさ調整</sys:String>
<sys:String x:Key="Strings.AdjustPosition">ウィンドウ位置を調整</sys:String>
<sys:String x:Key="Strings.Debug">デバッグコンソール</sys:String>
<sys:String x:Key="Strings.ChangeSettingsPath">設定保存先を上書き</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you translated "override" with "overwrite" here. I don't know Japanese, so I cannot suggest a better word, but these parts don't overwrite anything, they just tell Windower which directory to use for the respective files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then I prefer to translate it with "設定の保存先を変更".

<sys:String x:Key="Strings.Exit">終了</sys:String>
<sys:String x:Key="Strings.Crashed">Windowerは不具合によりクラッシュしました</sys:String>
<sys:String x:Key="Strings.CrashReporterPreparing">クラッシュに関する情報を収集しています</sys:String>
<sys:String x:Key="Strings.CrashReporterCheckingReport">この問題が既に修正されているか調べています</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this say "checking if already fixed"? Because it should be "checking if already reported".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mistranslate it and will correct as follows.

"この問題が既に報告されているか確認しています。"

<sys:String x:Key="Strings.CrashReporterCreatingComment">このクラッシュレポートに関するチケットにコメント</sys:String>
<sys:String x:Key="Strings.CrashReporterSubmitPrompt">Windower開発チームにクラッシュレポートを送信しますか?</sys:String>
<sys:String x:Key="Strings.CrashReporterSubmitDisclaimerEncrypted" xml:space="preserve">クラッシュレポートが生成されました。このレポートはWindower開発チームが問題を修正する一助となります。このクラッシュレポートには不具合発生時のWindowerとOSの状態に関する情報が含まれています。 収拾された情報は不具合修正のためだけに利用され、送信される前に暗号化されるので第三者が情報を読むことはありません。&#xD;&#xA;&#xD;&#xA;クラッシュレポートの送信にはGitHubアカウントが必要です。レポートはあなたのGitHubアカウントのgistとして送信され、チケットに関連付けられます。</sys:String>
<sys:String x:Key="Strings.CrashReporterSubmitDisclaimer" xml:space="preserve">クラッシュレポートが生成されました。このレポートはWindower開発チームが問題を修正する一助となります。このクラッシュレポートには不具合発生時のWindowerとOSの状態に関する情報が含まれています。 収拾された情報は不具合修正のためだけに利用され、送信される前に暗号化されるので第三者が情報を読むことはありません。&#xD;&#xA;&#xD;&#xA;クラッシュレポートの送信にはGitHubアカウントが必要です。レポートはあなたのGitHubアカウントのgistとして送信され、チケットに関連付けられます。</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the same as the entry before, CrashReporterSubmitDisclaimerEncrypted. Only the entry before should mention the encryption, this one should not.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it.

<sys:String x:Key="Strings.ElevationRequired">PlayOnline Viewerを実行するには管理者権限が必要です。</sys:String>
<sys:String x:Key="Strings.AdjustAccessControl">権限の調整</sys:String>
<sys:String x:Key="Strings.FixAccessControlPrompt">管理者権限が必要です</sys:String>
<sys:String x:Key="Strings.FixAccessControlDescription">現在、PlayOnline Viewerを実行するには管理者権限が必要です。PlayOnline Viewerが管理者権限なしで実行できるようにしますか?</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could you add that Windower will adjust POL so admin privileges are no longer required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will some words.

<sys:String x:Key="Strings.GammaFormat">{0:0.0}</sys:String>
<sys:String x:Key="Strings.Horizontal">水平位置</sys:String>
<sys:String x:Key="Strings.MaxSounds">効果音同時発音数</sys:String>
<sys:String x:Key="Strings.MaxSoundsFormat">{0:0;;Sound disabled}</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, why no translation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will translate it like "{0:0;;サウンド無効}"

<sys:String x:Key="Strings.TextureCompressionLow">標準</sys:String>
<sys:String x:Key="Strings.TextureCompressionUncompressed">高品質</sys:String>
<sys:String x:Key="Strings.UIScaleFormat">{0:0%}</sys:String>
<sys:String x:Key="Strings.AdjustGamma">明るさ調整</sys:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right translation? The FFXI config tool uses ガンマ補正.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust gamma translates to "ガンマ補正", but I choose the same words from Final Fantasy XI Config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants