Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrum 134 change language in tutorial #269

Closed
wants to merge 15 commits into from

Conversation

paalgf
Copy link
Contributor

@paalgf paalgf commented Nov 19, 2024

Description of your PR.

Definition of Done

Designs

  • The new changes are documented in the functional & technical designs.

Development and Testing

  • The new functionality has been tested by at least one of the other team members, and all tests are successful.
  • The test results are added to the test report documentation.
  • The implemented User Story complies with its acceptance criteria.
  • The new functionality is reviewed by at least two other team members.
  • The new functionality is compliant with the rules of chapter 6.2 Quality in the project plan.
  • The translations have been updated. Both the German and Dutch translations are up-to-date.

Unit, component & E2E testing

  • Unit tests are written for the general purpose code, e.g. libraries or utility methods
  • Component tests are written for standalone components, e.g. Buttons, Alerts
  • E2E tests are written for pages, e.g. the home page
  • E2E tests: Components use the "testID" attribute for testing

App testing

Build the app and test it on your phone.
This is important, because we've on a regular basis issues with the app on mobile phones, but not with the website.

  • Everything works as expected
  • No weird usability bugs
  • No errors or warnings during the tests
  • The browser console does not show any new errors or warnings (e.g. TouchableOpacity is deprecated)

Test app deployment

To prevent issues with the app deployment, it is highly recommended to test the app deployment at least once a day.

  • The app is deployed to the test environment
  • The build and deployment is successful
  • The app is fully working on the test environment

Please ensure that all the checkboxes are ticked before submitting the pull request.

@luximus-hunter
Copy link
Member

luximus-hunter commented Nov 20, 2024

@paalgf please merge development into this branch. After that I'll look at it again

@paalgf paalgf force-pushed the SCRUM-134-changeLanguageInTutorial branch from a1e222e to 4ddad23 Compare November 27, 2024 13:29
@paalgf paalgf closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants