Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/us143 implement high contrast mode #132

Merged
merged 12 commits into from
Nov 27, 2023

Conversation

KoenvanMeijeren
Copy link
Contributor

@KoenvanMeijeren KoenvanMeijeren commented Nov 27, 2023

Description of your PR.

Definition of Done

Designs

  • The new changes are documented in the functional & technical designs.

Development and Testing

  • The new functionality has been tested by at least one of the other team members, and all tests are successful.
  • The test results are added to the test report documentation.
  • The implemented User Story complies with its acceptance criteria.
  • The new functionality is reviewed by at least two other team members.
  • The new functionality is compliant with the rules of chapter 6.2 Quality in the project plan.

Unit, component & E2E testing

  • Unit tests are written for the general purpose code, e.g. libraries or utility methods
  • Component tests are written for standalone components, e.g. Buttons, Alerts
  • E2E tests are written for pages, e.g. the home page
  • E2E tests: Components use the "testID" attribute for testing

App testing

Build the app and test it on your phone.
This is important, because we've on a regular basis issues with the app on mobile phones, but not with the website.

  • Everything works as expected
  • No weird usability bugs
  • No errors or warnings during the tests

Please ensure that all the checkboxes are ticked before submitting the pull request.

src/constants/Colors.ts Show resolved Hide resolved
@KoenvanMeijeren KoenvanMeijeren merged commit 38ae162 into development Nov 27, 2023
3 checks passed
@KoenvanMeijeren KoenvanMeijeren deleted the feat/us143-implement-high-contrast-mode branch November 27, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants