Upgrade to Python 3 #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update .gitignore correspondingly
Some of these long floating point results are not stable, so we check them up to 7 digits of precision to ensure that they work.
The round() function was reimplemented in Python 3 to round to the nearest even number, instead of the higher one, in case of half-way points. Apparently this produces more accurate results over large data points, which would otherwise skew higher than expected. For more details, see: - https://docs.python.org/3/whatsnew/3.0.html#builtins - https://stackoverflow.com/q/10825926/6995854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades the code to Python 3.
Connects #71
Connects #16
Connects WikiWatershed/model-my-watershed#3165
Testing Instructions
pipenv install --devpipenv run nosetests --verbosity=2