Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine Python version support #16

Open
hectcastro opened this issue Apr 10, 2015 · 7 comments
Open

Determine Python version support #16

hectcastro opened this issue Apr 10, 2015 · 7 comments

Comments

@hectcastro
Copy link
Contributor

This is primarily to advertise the correct package classifiers on PyPI:

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 3',
@mmcfarland
Copy link
Contributor

Also, if the answer is 2 but it would be trivial to support 3, I think we should consider it. It's a fairly simple module.

@jamesmcclain
Copy link
Member

The code was not compatible with Python 3 before because of a few minor issues, but I have just put up a pull request #18 to fix that. One thing that I do not know about is how to support testing of both languages in the same project (I don't expect that it is difficult, I just don't know how to do it).

@hectcastro
Copy link
Contributor Author

From what I've seen thus far, other Python modules I've had to dig into use Tox for testing against multiple versions. Others may have more experience here though.

/cc @steventlamb

@steventlamb
Copy link

My experience is limited, I attempted to support python3 with django-queryset-csv, but backed out due to some stickiness with how the two different languages handled unicode, IIRC. However, when I was doing it, my strategy for testing was to rely on a free-for-FOSS cloud CI service like travisCI. Then, it's as simple as updating your .travis.yml to put python3 in the build matrix.

I have no experience with Tox.

If you're not going to free this repo, then I don't have much to offer. However, why would you bother supporting two different versions of python if this isn't going to be a public repo?

@hectcastro
Copy link
Contributor Author

However, when I was doing it, my strategy for testing was to rely on a free-for-FOSS cloud CI service like travisCI. Then, it's as simple as updating your .travis.yml to put python3 in the build matrix.

That's the plan here too once we settle on a license. The main driver for something like Tox is to support local testing across versions as well. For Travis, the build matrix would be driven by overrides to TOXENV vs. the python array of versions.

@mmcfarland
Copy link
Contributor

Once #6 & #5 are complete, let's set this up with the aim of being able to list v2 & 3, initial work has been done to verify that it should and the Travis build will keep it real.

@mmcfarland mmcfarland added this to the 2015-05-07 milestone Apr 23, 2015
@kdeloach
Copy link

kdeloach commented Nov 5, 2015

Is this done?

@kdeloach kdeloach removed this from the 2015-05-07 milestone Jan 19, 2016
@rajadain rajadain mentioned this issue Sep 23, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants