Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MW-310 Update LazyLoad comment #218

Merged
merged 1 commit into from
Sep 21, 2024
Merged

MW-310 Update LazyLoad comment #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM debian:12.5 as base

Check warning on line 1 in Dockerfile

View workflow job for this annotation

GitHub Actions / push

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

LABEL maintainers="[email protected],[email protected]"
LABEL org.opencontainers.image.source=https://github.com/WikiTeq/Taqasta
Expand All @@ -16,7 +16,7 @@
APACHE_LOG_DIR=/var/log/apache2

# System setup
RUN set x; \

Check failure on line 19 in Dockerfile

View workflow job for this annotation

GitHub Actions / test 

DL3047 info: Avoid use of wget without progress bar. Use `wget --progress=dot:giga <url>`.Or consider using `-q` or `-nv` (shorthands for `--quiet` or `--no-verbose`).
apt-get clean \
&& apt-get update \
&& apt-get --no-install-recommends install -y aptitude \
Expand Down Expand Up @@ -113,11 +113,11 @@
&& mkdir -p $MW_VOLUME

# Composer
RUN set -x; \

Check failure on line 116 in Dockerfile

View workflow job for this annotation

GitHub Actions / test 

DL4001 warning: Either use Wget or Curl but not both
curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer \
&& composer self-update 2.1.3

FROM base as core

Check warning on line 120 in Dockerfile

View workflow job for this annotation

GitHub Actions / push

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
# MediaWiki core
RUN set -x; \
git clone --depth 1 -b $MW_CORE_VERSION https://gerrit.wikimedia.org/r/mediawiki/core.git $MW_HOME \
Expand All @@ -139,7 +139,7 @@
cd $MW_HOME \
&& find . \( -name ".git" -o -name ".gitignore" -o -name ".gitmodules" -o -name ".gitattributes" \) -exec rm -rf -- {} +

FROM base as skins

Check warning on line 142 in Dockerfile

View workflow job for this annotation

GitHub Actions / push

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
# Skins
# The Minerva Neue, MonoBook, Timeless, Vector and Vector 2022 skins are bundled into MediaWiki and do not need to be
# separately installed.
Expand Down Expand Up @@ -179,7 +179,7 @@
cd $MW_HOME/skins \
&& find . \( -name ".git" -o -name ".gitignore" -o -name ".gitmodules" -o -name ".gitattributes" \) -exec rm -rf -- {} +

FROM base as extensions

Check warning on line 182 in Dockerfile

View workflow job for this annotation

GitHub Actions / push

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
# Extensions
#
# The following extensions are bundled into MediaWiki and do not need to be separately installed (though in some cases
Expand Down Expand Up @@ -774,7 +774,6 @@
RUN set -x; \
cd $MW_HOME/extensions \
# Lazyload
# TODO change me when https://github.com/mudkipme/mediawiki-lazyload/pull/15 will be merged
&& git clone https://github.com/mudkipme/mediawiki-lazyload.git $MW_HOME/extensions/Lazyload \
&& cd $MW_HOME/extensions/Lazyload \
&& git checkout -b $MW_VERSION 30a01cc149822353c9404ec178ec01848bae65c5 \
Expand Down Expand Up @@ -977,7 +976,7 @@
cd $MW_HOME/extensions \
&& find . \( -name ".git" -o -name ".gitignore" -o -name ".gitmodules" -o -name ".gitattributes" \) -exec rm -rf -- {} +

FROM base as composer

Check warning on line 979 in Dockerfile

View workflow job for this annotation

GitHub Actions / push

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

# Copy core, skins and extensions
COPY --from=core $MW_HOME $MW_HOME
Expand Down Expand Up @@ -1012,13 +1011,13 @@
&& ln -s $MW_VOLUME/images $MW_HOME/images \
&& ln -s $MW_VOLUME/cache $MW_HOME/cache

FROM base as final

Check warning on line 1014 in Dockerfile

View workflow job for this annotation

GitHub Actions / push

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

COPY --from=composer $MW_HOME $MW_HOME
COPY --from=composer $MW_ORIGIN_FILES $MW_ORIGIN_FILES

# Default values
ENV MW_AUTOUPDATE=true \

Check warning on line 1020 in Dockerfile

View workflow job for this annotation

GitHub Actions / push

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MW_PASSWORD_SENDER")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
MW_MAINTENANCE_UPDATE=0 \
MW_ENABLE_EMAIL=0 \
MW_ENABLE_USER_EMAIL=0 \
Expand Down
Loading