Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve getMediawikiSettings.php to bypass the SetupAfterCache hook #214

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Improve getMediawikiSettings.php to bypass the SetupAfterCache hook #214

merged 1 commit into from
Sep 25, 2024

Conversation

pastakhov
Copy link

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

🐳 The image based on b04f3d33 commit has been built with 1.39.8-20240901-214 tag as ghcr.io/wikiteq/taqasta:1.39.8-20240901-214

DanielWTQ
DanielWTQ approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@DanielWTQ DanielWTQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does what we want - though there might be some extensions that later have issues because they expect that hook to be called, its no different from issues from expecting the extension functions to be called

@pastakhov pastakhov merged commit 3b48192 into master Sep 25, 2024
2 checks passed
@pastakhov pastakhov deleted the SEL-1392/getMediawikiSettings branch September 25, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielWTQ DanielWTQ DanielWTQ approved these changes

@vedmaka vedmaka Awaiting requested review from vedmaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pastakhov @DanielWTQ