Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mayank/release/1.0.2 #17

Closed
wants to merge 18 commits into from
Closed

Mayank/release/1.0.2 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b02230d
Update gradle properties to accomodate fork
ncipollo May 5, 2022
7514ded
Update group and version name to point to whoop variant
ncipollo May 5, 2022
b323548
Expose recording option
ncipollo May 5, 2022
afca237
Prepare 1.100.1 release
ncipollo Jun 4, 2022
705eaae
Explicitly use cashapp's 1.1.0 release of `paparazzi-gradle-plugin` i…
chuck-stein Jan 11, 2023
adfc7d9
Prepare 1.101.1 release
chuck-stein Jan 12, 2023
346c596
Disable release signing because we don't have the signing key
chuck-stein Jan 13, 2023
8734b2d
Resolve conflicts
imayank91 Sep 29, 2023
cef49ea
Resolve conflicts
imayank91 Sep 29, 2023
4801928
Expose recording option
ncipollo May 5, 2022
52f7e7d
Prepare 1.100.1 release
ncipollo Jun 4, 2022
095d4da
Fix build.gradle
imayank91 Sep 29, 2023
29debcd
Resolve conflicts
imayank91 Sep 29, 2023
4ade8ff
Prepare 1.101.1 release
chuck-stein Jan 12, 2023
264378f
Disable release signing because we don't have the signing key
chuck-stein Jan 13, 2023
6a53323
Resolve conflicts
imayank91 Sep 29, 2023
d1f9ab1
Update gradle plugin
imayank91 Sep 29, 2023
8784ba7
Fix gradle.properties
imayank91 Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,21 @@
GROUP=app.cash.paparazzi
VERSION_NAME=1.3.1
GROUP=com.whoop.paparazzi
VERSION_NAME=1.102.0

POM_URL=https://github.com/cashapp/paparazzi/
POM_SCM_URL=https://github.com/cashapp/paparazzi/
POM_SCM_CONNECTION=scm:git:git://github.com/cashapp/paparazzi.git
POM_SCM_DEV_CONNECTION=scm:git:ssh://[email protected]/cashapp/paparazzi.git
POM_URL=https://github.com/WhoopInc/paparazzi/
POM_SCM_URL=https://github.com/WhoopInc/paparazzi/
POM_SCM_CONNECTION=scm:git:git://github.com/WhoopInc/paparazzi.git
POM_SCM_DEV_CONNECTION=scm:git:ssh://[email protected]/WhoopInc/paparazzi.git

POM_LICENCE_NAME=The Apache Software License, Version 2.0
POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt
POM_LICENCE_DIST=repo

POM_DEVELOPER_ID=cashapp
POM_DEVELOPER_NAME=CashApp
POM_DEVELOPER_URL=https://github.com/cashapp/
POM_DEVELOPER_URL=https://github.com/WhoopInc/

SONATYPE_HOST=DEFAULT
RELEASE_SIGNING_ENABLED=true
SONATYPE_AUTOMATIC_RELEASE=true
RELEASE_SIGNING_ENABLED=false

org.gradle.caching=true
org.gradle.parallel=true
org.gradle.jvmargs=-Xmx4g
android.useAndroidX=true

# Signals to our own plugin that we are building within the repo.
app.cash.paparazzi.internal=true

#app.cash.paparazzi.legacy.resource.loading=true
22 changes: 22 additions & 0 deletions paparazzi/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,25 @@ POM_ARTIFACT_ID=paparazzi
POM_NAME=Paparazzi
POM_DESCRIPTION=An Android library to render your application screens without a physical device or emulator
POM_PACKAGING=jar

GROUP=com.whoop.paparazzi
VERSION_NAME=1.101.1

POM_URL=https://github.com/WhoopInc/paparazzi/
POM_SCM_URL=https://github.com/WhoopInc/paparazzi/
POM_SCM_CONNECTION=scm:git:git://github.com/WhoopInc/paparazzi.git
POM_SCM_DEV_CONNECTION=scm:git:ssh://[email protected]/WhoopInc/paparazzi.git

POM_LICENCE_NAME=The Apache Software License, Version 2.0
POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt
POM_LICENCE_DIST=repo

POM_DEVELOPER_ID=cashapp
POM_DEVELOPER_NAME=CashApp
POM_DEVELOPER_URL=https://github.com/WhoopInc/

SONATYPE_HOST=DEFAULT
RELEASE_SIGNING_ENABLED=false

org.gradle.caching=true
org.gradle.parallel=true
8 changes: 4 additions & 4 deletions paparazzi/src/main/java/app/cash/paparazzi/HtmlReportWriter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ import javax.imageio.ImageIO
class HtmlReportWriter @JvmOverloads constructor(
private val runName: String = defaultRunName(),
private val rootDirectory: File = File("${System.getProperty("paparazzi.build.dir", "build")}/reports/paparazzi"),
snapshotRootDirectory: File = File("src/test/snapshots")
snapshotRootDirectory: File = File("src/test/snapshots"),
private val isRecording: Boolean = isRecordingDefault()
) : SnapshotHandler {
private val runsDirectory: File = File(rootDirectory, "runs")
private val imagesDirectory: File = File(rootDirectory, "images")
Expand All @@ -71,9 +72,6 @@ class HtmlReportWriter @JvmOverloads constructor(

private val shots = mutableListOf<Snapshot>()

private val isRecording: Boolean =
System.getProperty("paparazzi.test.record")?.toBoolean() == true

init {
runsDirectory.mkdirs()
imagesDirectory.mkdirs()
Expand Down Expand Up @@ -292,3 +290,5 @@ internal val filenameSafeChars = CharMatcher.inRange('a', 'z')
internal fun String.sanitizeForFilename(): String? {
return filenameSafeChars.negate().replaceFrom(toLowerCase(Locale.US), '_')
}

private fun isRecordingDefault() = System.getProperty("paparazzi.test.record")?.toBoolean() == true
Loading