This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Making it possible to push metrics in batches rather than one at a time #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
dogstatde
to push a lot of custom Datadog metrics, we'veobserved that the overhead of checking workers out & back in of the
dogstatsd_worker
wpool
can become a performance bottleneck.This patch makes it possible to submit several metrics of the same type
at one time, hence allowing for a single worker check-out/in cycle to submit
them all, for example:
We've deployed that in production, and found a noticeable difference in our
use case.
This patch should be entirely backward-compatible.
Updated tests, and added a few more.