resolve #771 #772
Open
resolve #771 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate build script to echo correct build directory path
crramirez
requested changes
Jul 20, 2023
| @@ -30,27 +30,27 @@ | |||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration"> | |||
| <ConfigurationType>Application</ConfigurationType> | |||
| <UseDebugLibraries>true</UseDebugLibraries> | |||
| <PlatformToolset>v143</PlatformToolset> | |||
| <PlatformToolset>v142</PlatformToolset> | |||
There was a problem hiding this comment.
As the automated process to publish the program to the store uses Visual Studio 2022, it is preferable to update the BUILDING.md to use it.
Suggested change
| <PlatformToolset>v142</PlatformToolset> | |
| <PlatformToolset>v143</PlatformToolset> |
There was a problem hiding this comment.
Alright. I'll revert these changes in the next push to this PR.
I'm working on build instructions using VS 2022 and the non-legacy rootfs build repo, but I'm running into unrelated issues with debootstrap failing to successfully install sudo in the rootfs.
| <CharacterSet>Unicode</CharacterSet> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'" Label="Configuration"> | ||
| <ConfigurationType>Application</ConfigurationType> | ||
| <UseDebugLibraries>true</UseDebugLibraries> | ||
| <PlatformToolset>v143</PlatformToolset> | ||
| <PlatformToolset>v142</PlatformToolset> |
There was a problem hiding this comment.
Suggested change
| <PlatformToolset>v142</PlatformToolset> | |
| <PlatformToolset>v143</PlatformToolset> |
| <CharacterSet>Unicode</CharacterSet> | ||
| <WindowsSDKDesktopARM64Support>true</WindowsSDKDesktopARM64Support> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration"> | ||
| <ConfigurationType>Application</ConfigurationType> | ||
| <UseDebugLibraries>false</UseDebugLibraries> | ||
| <PlatformToolset>v143</PlatformToolset> | ||
| <PlatformToolset>v142</PlatformToolset> |
There was a problem hiding this comment.
Suggested change
| <PlatformToolset>v142</PlatformToolset> | |
| <PlatformToolset>v143</PlatformToolset> |
| <WholeProgramOptimization>true</WholeProgramOptimization> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'" Label="Configuration"> | ||
| <ConfigurationType>Application</ConfigurationType> | ||
| <UseDebugLibraries>false</UseDebugLibraries> | ||
| <PlatformToolset>v143</PlatformToolset> | ||
| <PlatformToolset>v142</PlatformToolset> |
There was a problem hiding this comment.
Suggested change
| <PlatformToolset>v142</PlatformToolset> | |
| <PlatformToolset>v143</PlatformToolset> |
| @@ -16,7 +16,7 @@ | |||
| <Keyword>Win32Proj</Keyword> | |||
| <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion> | |||
| <ConfigurationType>Application</ConfigurationType> | |||
| <PlatformToolset>v143</PlatformToolset> | |||
| <PlatformToolset>v142</PlatformToolset> | |||
There was a problem hiding this comment.
Suggested change
| <PlatformToolset>v142</PlatformToolset> | |
| <PlatformToolset>v143</PlatformToolset> |
| @@ -29,7 +29,7 @@ | |||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration"> | |||
| <ConfigurationType>Application</ConfigurationType> | |||
| <UseDebugLibraries>true</UseDebugLibraries> | |||
| <PlatformToolset>v143</PlatformToolset> | |||
| <PlatformToolset>v142</PlatformToolset> | |||
There was a problem hiding this comment.
Suggested change
| <PlatformToolset>v142</PlatformToolset> | |
| <PlatformToolset>v143</PlatformToolset> |
| @@ -41,7 +41,7 @@ | |||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration"> | |||
| <ConfigurationType>Application</ConfigurationType> | |||
| <UseDebugLibraries>false</UseDebugLibraries> | |||
| <PlatformToolset>v143</PlatformToolset> | |||
| <PlatformToolset>v142</PlatformToolset> | |||
There was a problem hiding this comment.
Suggested change
| <PlatformToolset>v142</PlatformToolset> | |
| <PlatformToolset>v143</PlatformToolset> |
| @@ -102,14 +102,15 @@ goto :ARGS_LOOP | |||
|
|
|||
| :POST_ARGS_LOOP | |||
| %MSBUILD% %~dp0\DistroLauncher.sln /t:%_MSBUILD_TARGET% /m /nr:true ^ | |||
| /restore ^ | |||
There was a problem hiding this comment.
Use spaces
Suggested change
| /restore ^ | |
| /restore ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #771, which is ultimately the result of multiple independent issues related to building.
Because there are a couple different ways to resolve the issues I encountered, there's room for discussion on exactly how fixes should be implemented upstream. I'll try to reference specific issues and pertinent details in this PR and then update BUILDING.md in a subsequent commit to document/reflect the agreed on changes to what the build process should look like.
First and foremost are the changes proposed in WhitewaterFoundry/legacy-rootfs-build-scripts#1 -- getting pengwin-base built successfully first is critical. Some changes were needed so the script would continue to work as intended. As proposed, it is intended to work with the linux_files/setup file already in this repository instead of the one in the legacy-rootfs-build-scripts. Alternatively, perhaps one of the non-legacy scripts in https://github.com/WhitewaterFoundry/pengwin-rootfs-builds can referenced in build docs and used instead.
The next major issue is dependencies and the VS build environment. Current documentation recommends VS 2019, but platform tools v143 is not compatible/available on VS 2019. See the changes to .vcxproj files.
Past that, I encountered extensive NuGet dependency issues that were ultimately resolved by the changes made to build.bat to automatically restore dependencies. Other issues that were resolved without changes to specific scripts were where to modify the package thumbprint and exact steps related to trusting the signing certificate before the msixbundle is allowed to be installed.