Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Updating JSON conversion tool for new strategic plans FY 2019 & FY 2020 #117

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

krusynth
Copy link
Contributor

Updating JSON schema & conversion tool to account for 2019 & 2020 strategic plans.

@vasili4
Copy link
Contributor

vasili4 commented Nov 8, 2018

Looks good. Using json-loader helps using raw schema.json without any modifications, good idea.
After applying this patch I see some javascript warnings, not breaking functionality though. Happens because some libraries got updated. I was trying to get rid of them but that turns out to complete refactoring of the tool, that should be a different pull request.

@vasili4
Copy link
Contributor

vasili4 commented Nov 8, 2018

Internet Explorer 11 is throwing an Exception, it is working fine with old version. Don't merge yet

@vasili4
Copy link
Contributor

vasili4 commented Nov 9, 2018

I know it's not a very popular browser today, but don't want to break IE11 support by updating json schema. I've created a new pull request that includes these commits and also restores IE11 support #118

@vasili4
Copy link
Contributor

vasili4 commented Nov 9, 2018

please close this PR and merge #118 instead thanks

@krusynth krusynth force-pushed the gh-pages branch 2 times, most recently from 7100245 to d6b9919 Compare November 26, 2018 03:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants