Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pool): ampMNTA-WHALE #424

Merged
merged 4 commits into from
Nov 14, 2023
Merged

fix(pool): ampMNTA-WHALE #424

merged 4 commits into from
Nov 14, 2023

Conversation

0xFable
Copy link
Contributor

@0xFable 0xFable commented Nov 9, 2023

Description and Motivation

Related Issues

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly yarn lint.
  • The project builds and is able to deploy on Netlify yarn build.

@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for exquisite-salamander-a1fe5e ready!

Name Link
🔨 Latest commit d34fc31
🔍 Latest deploy log https://app.netlify.com/sites/exquisite-salamander-a1fe5e/deploys/65526319d75a3500077345ab
😎 Deploy Preview https://deploy-preview-424--exquisite-salamander-a1fe5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 95 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

worrex
worrex reviewed Nov 9, 2023
View reviewed changes
public/mainnet/migaloo-1/pools_list.json Outdated
@@ -309,45 +309,46 @@
"rewards_tokens": []
},
{
"pool_id": "WHALE-ampMNTA",
"pool_id": "ampMNTA-WHALE",
"lpOrder": [
"WHALE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lp order needs to be changed as well

@worrex worrex marked this pull request as ready for review November 13, 2023 11:18
@0xFable 0xFable changed the title fix(pool-order): Swap order on FE for pool fix(pool): ampMNTA-WHALE Nov 13, 2023
@0xFable 0xFable merged commit b05235a into main Nov 14, 2023
3 of 4 checks passed
@nick134-bit nick134-bit deleted the fix/reorder-ampMNTA-pool branch May 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worrex worrex worrex left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xFable @worrex