Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump terra core #390

Merged
merged 12 commits into from
Jul 5, 2024
Merged

feat: bump terra core #390

merged 12 commits into from
Jul 5, 2024

Conversation

duvbell
Copy link
Contributor

@duvbell duvbell commented Jul 5, 2024 •
edited by faddat
Loading

Description and Motivation

  • Upgrade of Migaloo's major dependencies
    • Luna
    • Alliance
    • cosmos-sdk
    • ibc
    • comet
    • cometbft-db

Related Issues

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

@faddat
Copy link
Collaborator

faddat commented Jul 5, 2024

Because we are bumping other module versions, let's take this opportunity to upgrade everything else.

@faddat
Copy link
Collaborator

faddat commented Jul 5, 2024

we also need to update go in the ci system

@faddat
Copy link
Collaborator

faddat commented Jul 5, 2024

...and in Docker....

faddat
faddat requested changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a new branch, release/v4.2.x and this should be tagged as v4.2.x because of breaking changes.

@faddat faddat enabled auto-merge (squash) July 5, 2024 07:49
hoank101
hoank101 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@hoank101 hoank101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faddat faddat disabled auto-merge July 5, 2024 08:01
@faddat faddat merged commit 076c6d1 into release/v4.1.x Jul 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoank101 hoank101 hoank101 approved these changes

@faddat faddat faddat approved these changes

@PolkachuIntern PolkachuIntern Awaiting requested review from PolkachuIntern

@Sen-Com Sen-Com Awaiting requested review from Sen-Com Sen-Com is a code owner

@kerber0x kerber0x Awaiting requested review from kerber0x kerber0x is a code owner

@0xFable 0xFable Awaiting requested review from 0xFable 0xFable is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duvbell @faddat @hoank101