Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use thelper in golangci-lint #143

Merged
merged 2 commits into from
Apr 18, 2023
Merged

use thelper in golangci-lint #143

merged 2 commits into from
Apr 18, 2023

Conversation

faddat
Copy link
Collaborator

@faddat faddat commented Apr 11, 2023

Description and Motivation

This PR enables the thelper linter, which adds additional rigor around tests.

Related Issues

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 11, 2023
View reviewed changes
app/test_access.go Fixed Show fixed Hide fixed
anhductn2001
anhductn2001 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@anhductn2001 anhductn2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @faddat

@vuong177 vuong177 enabled auto-merge April 12, 2023 04:17
@faddat faddat disabled auto-merge April 18, 2023 16:57
@faddat faddat merged commit 534f3a6 into release/v3.0.x Apr 18, 2023
@hoank101 hoank101 deleted the use-thelper branch March 22, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdv2429 hoangdv2429 hoangdv2429 approved these changes

@anhductn2001 anhductn2001 anhductn2001 approved these changes

@pysel pysel pysel approved these changes

@ThanhNhann ThanhNhann ThanhNhann approved these changes

@PolkachuIntern PolkachuIntern Awaiting requested review from PolkachuIntern

@Sen-Com Sen-Com Awaiting requested review from Sen-Com Sen-Com is a code owner

@kerber0x kerber0x Awaiting requested review from kerber0x kerber0x is a code owner

@0xFable 0xFable Awaiting requested review from 0xFable 0xFable is a code owner

@vuong177 vuong177 Awaiting requested review from vuong177

@hieuvubk hieuvubk Awaiting requested review from hieuvubk

@GNaD13 GNaD13 Awaiting requested review from GNaD13

@phamminh0811 phamminh0811 Awaiting requested review from phamminh0811

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faddat @ThanhNhann @pysel @anhductn2001 @hoangdv2429