Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables/disables directional buttons and play/pause based on the gcode uploader #170

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thormj
Copy link

@thormj thormj commented Jul 11, 2020

Instead of popping up error messages, I figure I should disable the buttons...

</div>
<div class="col-3 mb-1">
<button type="button" class="btn btn-dark btn-block" onclick="moveAction('right')"><i data-feather="arrow-right"></i></button>
<button type="button" class="btn btn-dark btn-block disabler disabler" onclick="moveAction('right')"><i data-feather="arrow-right"></i></button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabler appears twice

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.. fixed and added it to the Change Units button.
Do I need to make a new pull request, or does the pull request follow the branch?

@gb0101010101
Copy link
Contributor

@thormj Don't spend any more time on the "disabler" stuff. I have already done this but the Pull Request got lost during renaming of this project and I am waiting on #117 to be committed before I resubmit it. See master...gb0101010101:gb0101010101-test-ui-states

@thormj
Copy link
Author

thormj commented Jul 15, 2020

K. Was just looking around for simple things to fix to learn how it all goes together. Should I close the conversation and pull request or ?

@gb0101010101
Copy link
Contributor

@thormj Leave everything as is for now. I will hopefully be clearing issues and PRs in the next week.
Sorry we are in a state of flux right now as this project switched from 'personal' to 'organization' repo to open it to a wider group of people.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants