Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E - Enhance Mandatory MFA scenarios if the token is invalid #389

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

LeVinhGithub
Copy link
Contributor

@LeVinhGithub LeVinhGithub commented Aug 20, 2024

Motivation and Context

Test is not stable sometimes because of the invalid token
Work around to re-input the token

Jira Link:
https://toruslabs.atlassian.net/browse/PD-3787
https://github.com/Web3Auth/web3auth-e2e-tests/actions/runs/10463993434

Description

Increase the timeout to 120s
Handle to re-input the token

How has this been tested?

Run locally
Check by Github action

Screenshots (if appropriate):

Types of changes

Enhance script

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@LeVinhGithub LeVinhGithub self-assigned this Aug 20, 2024
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 712c051 into master Aug 20, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the harry/enhance-mandatory-mfa branch August 20, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants