-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Telegram MiniApp #689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yashovardhan
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Deployment failed with the following error:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Telegram MiniApp with Improved Theming, Responsiveness, Accessibility, and Code Organization
Motivation and Context
This update enhances the Telegram MiniApp to ensure brand consistency with Web3Auth, improve user experience across different themes (light and dark modes), and provide a more responsive, accessible, and performant interface. Additionally, it addresses several layout, styling, and usability bugs.
This change was required to create a more polished and professional user interface, aligning closely with Web3Auth's design guidelines while ensuring the app is accessible and performs well across various screen sizes and devices.
Jira Link: DEVREL-1057
Description
Changes Made
Theme Implementation
:root
for easy theme management.#0F1221
).Layout & Spacing
max-width: min(600px, 90%)
for optimal readability.Responsive Design
clamp()
for responsive font sizing, ensuring readability on all devices.width: min(180px, 40%)
for optimal display.Typography & Styling
Component Styling
Performance & Best Practices
box-sizing: border-box
for consistent sizing.Brand Consistency
Bug Fixes
Accessibility
Code Organization
How has this been tested?
The following testing steps were taken to ensure functionality and stability:
Screenshots (if appropriate)
Types of Changes
Checklist