Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mpc corekit webview ed25519 #685

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Oct 24, 2024

Motivation and Context

Jira Link:

Description

mpc-corekit-rn webview solana example

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpc-core-kit-aggregate-verifier-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
mpc-core-kit-angular-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
mpc-core-kit-bitcoin ❌ Failed (Inspect) Dec 20, 2024 9:17am
mpc-core-kit-farcaster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
mpc-core-kit-nextjs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
mpc-core-kit-react-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
mpc-core-kit-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
mpc-core-kit-vue-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-angular-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-nextjs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-react-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-vanillajs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-vue-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-aggregate-verifier-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-auth0-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-bitcoin-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-farcaster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-google-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-nextauth-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-passwordless-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-ton-telegram-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
sfa-web-ton-telegram-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am
web3auth-core-kit-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:17am

@AyushBherwani1998
Copy link
Member

Issues:

  • After enableMFA sometimes the login gives setMetadata errored Load failed
  • Create Factor also sometimes gives the setMetadata errored Load Failed
  • EnableMFA doesn't delete hashed factor

@shahbaz17
Copy link
Member

Login works, and all function works too.

  • It's just that when MFA is already enabled and clicked on enable MFA button, it creates a new factor, checked with the Key Details button.
    Rather, it should say, that MFA is already enabled, and no factors should be created.

cc @ieow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants