Merge pull request #198 from Web3Auth/fix/tss-encoding

mpc utils: fix signature encoding
Web3Auth · Sep 4, 2023 · a08f675 · a08f675
2 parents 6a1394a + e2c2a0a
commit a08f675
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/mpc-core-kit/tkey-mpc-react-bitcoin-example/src/utils.ts b/mpc-core-kit/tkey-mpc-react-bitcoin-example/src/utils.ts
@@ -109,11 +109,7 @@ export const setupWeb3 = async (loginReponse: any, signingParams: any) => {
         signatures,
       });
       await client.cleanup(tss, { signatures, server_coeffs: serverCoeffs });
-      const sig = {
-        v: recoveryParam,
-        r: Buffer.from(r.toString("hex").padStart(64, "0"), "hex"),
-        s: Buffer.from(s.toString("hex").padStart(64, "0"), "hex"),
-      };
+      const sig = { v: recoveryParam, r: r.toArrayLike(Buffer, "be", 32), s: s.toArrayLike(Buffer, "be", 32) };
       const sigBuffer = Buffer.concat([sig.r, sig.s]);
       return Promise.resolve(sigBuffer);
     };

diff --git a/mpc-core-kit/tkey-mpc-react-firebase-example/src/utils.ts b/mpc-core-kit/tkey-mpc-react-firebase-example/src/utils.ts
@@ -141,7 +141,7 @@ export const setupWeb3 = async (chainConfig: Omit<CustomChainConfig, "chainNames
         signatures,
       });
       await client.cleanup(tss, { signatures, server_coeffs: serverCoeffs });
-      return { v: recoveryParam, r: Buffer.from(r.toString("hex"), "hex"), s: Buffer.from(s.toString("hex"), "hex") };
+      return { v: recoveryParam, r: r.toArrayLike(Buffer, "be", 32), s: s.toArrayLike(Buffer, "be", 32) };
     };
 
     if (!compressedTSSPubKey) {

diff --git a/mpc-core-kit/tkey-mpc-react-popup-example/src/utils.ts b/mpc-core-kit/tkey-mpc-react-popup-example/src/utils.ts
@@ -141,7 +141,7 @@ export const setupWeb3 = async (chainConfig: Omit<CustomChainConfig, "chainNames
         signatures,
       });
       await client.cleanup(tss, { signatures, server_coeffs: serverCoeffs });
-      return { v: recoveryParam, r: Buffer.from(r.toString("hex"), "hex"), s: Buffer.from(s.toString("hex"), "hex") };
+      return { v: recoveryParam, r: r.toArrayLike(Buffer, "be", 32), s: s.toArrayLike(Buffer, "be", 32) };
     };
 
     if (!compressedTSSPubKey) {