-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4: feat: remote signer #185
Conversation
c33d0d0
to
ef7e61f
Compare
remoteSigner
fix rehydration
5f8870f
to
57472c3
Compare
src/mpcCoreKit.ts
Outdated
@@ -934,10 +970,182 @@ export class Web3AuthMPCCoreKit implements ICoreKit { | |||
} | |||
} | |||
|
|||
async setupRemoteSigning(params: Omit<IRemoteClientState, "tssShareIndex" | "signatures">): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this function can be moved to plugin itself
src/mpcCoreKit.ts
Outdated
msgHash: msgData.toString("hex"), | ||
}; | ||
|
||
const result = await post<{ data?: Record<string, string> }>(`${this.state.remoteClient.remoteClientUrl}/api/v3/mpc/sign/dkls`, data, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this logic should be moved to a function in plugin so that we can be decoupled from api endpoints here, i think another way to do it is to do it directly inside existing sign function since most of the code is same and call the remoteSign function same as we are doing for copyShare logic.
}; | ||
await this.sessionManager.createSession(payload); | ||
// to accommodate async storage | ||
await this.currentStorage.set("sessionId", sessionId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function should be moved to plugin as well
close in favor of #209 |
remoteSigner
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: