2.1.0 release

[Rudloff]

@Roboe Is there anything else to do before a new release?

[Roboe]

Could we merge #16 before releasing? Just for making a good first-impression for new users.

Also, what about repo metadata? It's a good time for including that in the repo Ok, forget about this, it's not crucial. We can include it in a future release. Changelog is there already, 👍

[Roboe]

The "Show mem" title is an error on the F-Droid side, right? I guess that will be updated accordingly with a newer release, without we doing anything?

[Rudloff]

The wrong name is caused by this issue in Androguard: androguard/androguard#501
I'm not sure we can fix it on our side.

[Roboe]

We can just drop a title.txt file in the metadata for a workaround, but maybe @Bubu doesn't want to lose his/her testing app?

[Rudloff]

Yes, I think we should do this because the current name is clearly confusing users

[Bubu]

I tried to fix this here already: f-droid/fdroiddata@5416e23

But for some reason that didn't work (either strange handling of localized vs non-localized metadata or a caching issue on the fdroid server.)

Having a title.txt is a good next step in trying to set the name straight :).

[Rudloff]

I think you changed the wrong metadata. The correct ID is community.fairphone.fplauncher3.

[Roboe]

Yup, that seems to be @Kwamecorp's launcher for the Fairphone 1. Ours is a community fork of the Fairphone Launcher 3 for the Fairphone 2

[Bubu]

Oh... thanks for noticing. I can fix this tomorrow. (or I can merge a MR later.)

[Roboe]

Don't worry, @Bubu, #19 should fix the title issue, 👍

[reox]

I changed the behaviour of getting the app name in androguard already - but there is no new version released yet. Can you test if the current master of androguard gives the desired name? As I explained in androguard/androguard#501 , the manifest file is tricky to parse and the androguard parser is not aware of many resources.
The current process of extracting the name is:

1. look at the application tag
2. look at the main activity
   (see https://github.com/androguard/androguard/blob/master/androguard/core/bytecodes/apk.py#L259)

the problem with this app is, that the main activity is not determined correctly - also androguard is not aware of launcher activities.

[Rudloff]

@reox I tried androguard v3.2.0-28-gfab3663 on dad84f2 and get_app_name() successfully returns Fairphone Launcher 3.

[Bubu]

Removed the name setting from the wrong appid. Can't set it for the correct one either because then lint complains about name being equal to auto-name (this is rather inconstistent behaviour of fdroid but before we can et this fixed we;re faster in waiting for you to set the name from title.txt here :))

[Roboe]

I think it's time to merge this and release 2.1.0 because #17 doesn't seem straightforward to fix.

[Rudloff]

@Roboe Do you want to create the Git tag or do you want me to do it?

[Roboe]

Can you handle it and update F-Droid's metadata too? Thank you!

[ildar]

#7 ? Though "Release early, release often" so I'd want to see any version, even buggy ))

[Rudloff]

I don't think any of us knows how to fix #7 😞
(And #10 fixes installation on a lot of devices so I think it is a good idea to release it now.)

[Rudloff]

@Roboe I tagged the release. F-Droid should update automatically.

[Roboe]

I was referring to this too:

Once an app’s descriptive texts have been moved into the source repo, then file a merge request or issue to remove Summary and Description from the app’s metadata file.

https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#in-the-apps-source-repository

[Rudloff]

Oh I totally forgot about this. I will submit a merge request.

Edit: https://gitlab.com/fdroid/fdroiddata/merge_requests/3275